style: resolve analyzer issues across all packages#252
Open
spydon wants to merge 5 commits into
Open
Conversation
The json_serializable / json_annotation versions used need Dart 3.8.0. Constraints are left as-is so consumers on Dart 3.8.0 still resolve the 3.8-compatible json versions rather than being forced to 3.9.0.
Add doc comments for public members, suppress API-breaking lints via ignore directives without changing public APIs, and apply safe local fixes. Generated files and corbado_auth_firebase (broken, separate PR) are out of scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brings
melos run analyze(dart analyze --fatal-infos) to zero issues for every package exceptcorbado_auth_firebase(see below).dart fix --applyfor the mechanically-fixable lints (annotate_overrides,prefer_const_constructors,use_super_parameters,unused_import,directives_ordering, etc.).///doc comments for ~545public_member_api_docsviolations across the packages.print→debugPrint, addedcontext.mountedguards (use_build_context_synchronously), explicit type arguments (inference_failure_*),StringBufferusage,@deprecated→@Deprecated('...'), etc.analyzer: exclude: ['**/*.g.dart']to the analysis options, and suppressed the few lints in the vendoredtelemetry_api_client.API-breaking lints are suppressed, not "fixed"
Some lints can only be resolved by changing public APIs (renaming public constants/files, changing method signatures, replacing public static factory methods). Per the decision to avoid breaking changes, these are silenced with targeted
// ignore_for_file:/// ignore:directives rather than altered:constant_identifier_names,non_constant_identifier_names,file_names,avoid_positional_boolean_parameters,prefer_constructors_over_static_methods,library_private_types_in_public_api,use_setters_to_change_properties. No public identifier, file name, or signature was changed.Out of scope
corbado_auth_firebaseis not included — it currently does not compile (pre-existingundefined_getter), so its lints can't be validated. It will be fixed in a separate follow-up PR.Verification
melos run analyzereports 0 issues for all packages exceptcorbado_auth_firebase.melos run format:checkpasses (435 files, 0 changed).Merge order
Stacked on #251 → #250. Merge those first; this diff then reduces to just the analyzer fixes.