fix: show digest on push and drop empty annotations#148
Open
Bisman-Singh wants to merge 1 commit into
Open
Conversation
When pushing via CLI, print the actual digest (sha256:...) instead of dumping the raw Response object. Also skip adding customProperties annotation when it's empty. Fixes containers#18, Fixes containers#19 Signed-off-by: Bisman-Singh <bismanmadaan1@gmail.com>
Author
|
@tarilabs would you mind taking a look when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does:
pushnow printsPushed target@sha256:...instead of the raw Response objectto_annotations_dict()skips emptycustomPropertiesinstead of adding a uselesscustomProperties+json: {}annotationChanges:
cli.py: extractDocker-Content-Digestheader from push responsemodel_metadata.py: skip empty dicts in annotation generationFixes #18
Fixes #19