Allow Symfony 8#1187
Conversation
030e456 to
a771823
Compare
|
@weitzman please take a look as the removed |
|
Do any of these tests run with Symfony 7 now? We'll want to either add that, or drop Symfony 7 support and make a new major release. I think it's safe to add the return typehint and still override an older version that has no return typehint. Might need a returntypemaychange annotation. I don't specifically know about Applicatoin::add(), but with all of the tests green, looks like we might not need it. |
|
Hello @andypost, Do you know when symfony 8 will be allowed ? |
|
It's already but what for? |
|
@andypost I am doing an upgrade to symfony 8. I use this package edgedesign/phpqa which have a dependancy to this package but consolidation/robo doesn't support symfony 8 on their lastest version so now the package use 0.5 version which doesn't work |
Widen symfony/* constraints to allow ^8.
No code changes needed — verified that the APIs used by this package are unchanged in Symfony 8.
Note: check if Application::add() is used — it was removed in SF8, replaced by addCommand().
Ref: drush-ops/drush#6536