Skip to content

Allow Symfony 8#1187

Open
andypost wants to merge 1 commit into
consolidation:5.xfrom
skilld-labs:sf8
Open

Allow Symfony 8#1187
andypost wants to merge 1 commit into
consolidation:5.xfrom
skilld-labs:sf8

Conversation

@andypost

Copy link
Copy Markdown
Contributor

Widen symfony/* constraints to allow ^8.

No code changes needed — verified that the APIs used by this package are unchanged in Symfony 8.

Note: check if Application::add() is used — it was removed in SF8, replaced by addCommand().

Ref: drush-ops/drush#6536

@andypost andypost force-pushed the sf8 branch 5 times, most recently from 030e456 to a771823 Compare March 19, 2026 12:52
@andypost

andypost commented Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

@weitzman please take a look as the removed add() method probably needs major release and cut off PHP 7

@greg-1-anderson

Copy link
Copy Markdown
Member

Do any of these tests run with Symfony 7 now? We'll want to either add that, or drop Symfony 7 support and make a new major release. I think it's safe to add the return typehint and still override an older version that has no return typehint. Might need a returntypemaychange annotation.

I don't specifically know about Applicatoin::add(), but with all of the tests green, looks like we might not need it.

@Davidshb

Copy link
Copy Markdown

Hello @andypost, Do you know when symfony 8 will be allowed ?

@andypost

Copy link
Copy Markdown
Contributor Author

It's already but what for?

@Davidshb

Copy link
Copy Markdown

@andypost I am doing an upgrade to symfony 8. I use this package edgedesign/phpqa which have a dependancy to this package but consolidation/robo doesn't support symfony 8 on their lastest version so now the package use 0.5 version which doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants