Repository navigation
Conversation
The arm64 confidential-data-hub test job intermittently fails in
secret::tests::serialize_deserialize::case_2:
deserialization failed:
JsonError(Error("EOF while parsing a value", line: 1, column: 0))
The sealed-secret tests run concurrently while sharing the same signing
credential file at
/run/confidential-containers/cdh/sealed-secret/test-key. Each test
rewrites this file with std::fs::write, which first truncates it. A
concurrent reader can therefore observe an empty file before the JSON
content has been written.
Serialize serialize_deserialize, check_tampering, and check_wrong_key,
which are the tests that access this shared credential. This prevents
concurrent writes and reads without changing production behavior.
Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arm64 confidential-data-hub test job intermittently fails in secret::tests::serialize_deserialize::case_2:
The sealed-secret tests run concurrently while sharing the same signing credential file at /run/confidential-containers/cdh/sealed-secret/test-key. Each test rewrites this file with std::fs::write, which first truncates it. A concurrent reader can therefore observe an empty file before the JSON content has been written.
Serialize serialize_deserialize, check_tampering, and check_wrong_key, which are the tests that access this shared credential. This prevents concurrent writes and reads without changing production behavior.