-
Notifications
You must be signed in to change notification settings - Fork 2
feat: model evidence lifecycle as three outcome event types on complyapi.* subjects #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4cc472d
feat: validate subjectId as a safe NATS subject token
jpower432 da4216b
fix: make storageRef required and URI-scheme-prefixed on evidence.ing…
jpower432 87a9e82
feat: add dev.complytime.evidence.sealed and .quarantined event types
jpower432 0aa5e81
fix: restore storageRef non-empty check in ConformToSchema test
jpower432 0e205c0
docs: fix subject hierarchy description, document new event types, bu…
jpower432 1bf933b
fix: enforce contentDigest/artifactType at construction time
jpower432 6cf4a13
refactor: rename NATS subject domain segment from core to complyapi
jpower432 896a492
refactor: drop shardId from evidence data structs
jpower432 a06f79e
feat: require storageRef on sealed events, validate example payloads
jpower432 9ba1b8e
chore: apply suggestions from code review
jpower432 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "specversion": "1.0", | ||
| "id": "c3d4e5f6-a7b8-9012-cdef-123456789012", | ||
| "type": "dev.complytime.evidence.quarantined", | ||
| "source": "complytime-worker", | ||
| "subject": "my-app-v1", | ||
| "time": "2026-08-20T14:32:00Z", | ||
| "datacontenttype": "application/json", | ||
| "data": { | ||
| "contentDigest": "sha256:9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08", | ||
| "artifactType": "application/vnd.gemara.evaluation-log+json", | ||
| "subjectId": "my-app-v1", | ||
| "reason": "content digest mismatch" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "specversion": "1.0", | ||
| "id": "b2c3d4e5-f6a7-8901-bcde-f12345678901", | ||
| "type": "dev.complytime.evidence.sealed", | ||
| "source": "complytime-worker", | ||
| "subject": "my-app-v1", | ||
| "time": "2026-08-20T14:31:00Z", | ||
| "datacontenttype": "application/json", | ||
| "data": { | ||
| "contentDigest": "sha256:9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08", | ||
| "artifactType": "application/vnd.gemara.evaluation-log+json", | ||
| "storageRef": "s3://evidence/9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08", | ||
| "subjectId": "my-app-v1" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,12 +12,8 @@ | |
| "description": "SHA-256 digest of the evidence artifact", | ||
| "type": "string" | ||
| }, | ||
| "shardId": { | ||
| "description": "Subject shard identifier (null when sharding is not configured)", | ||
| "type": "string" | ||
| }, | ||
| "storageRef": { | ||
| "description": "Internal storage reference", | ||
| "description": "URI-style storage reference consumers use to fetch the evidence artifact (must include a scheme prefix, e.g. s3://, gcp://, locker://)", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Much better description. Thanks for this update.
jpower432 marked this conversation as resolved.
Outdated
|
||
| "type": "string" | ||
| }, | ||
| "subjectId": { | ||
|
|
@@ -28,6 +24,7 @@ | |
| "required": [ | ||
| "contentDigest", | ||
| "artifactType", | ||
| "storageRef", | ||
| "subjectId" | ||
| ], | ||
| "type": "object" | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.