Skip to content

feat: add evidence-locker-mvp-reviewers team #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beatrizmcouto wants to merge 2 commits into
base: main
Choose a base branch
from
+41 −0
Open

feat: add evidence-locker-mvp-reviewers team #204

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
860ed0a
feat: add evidence-locker-mvp-reviewers team
beatrizmcouto Aug 20, 2026
69c917f
Grant evidence-locker-mvp-reviewers maintain on nunya.
beatrizmcouto Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions MAINTAINING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,18 @@ already a member) but it triggers a false-positive drift alert.
3. Ensure admins are listed as `maintainers`, not `members` (CI validates).
4. Submit a PR and merge.

### Evidence Locker MVP reviewers

`evidence-locker-mvp-reviewers` is the reviewer pool for issues and pull
requests whose milestone title is **Evidence Locker MVP** (or **Internal
Evidence Locker MVP**). Membership is the source of truth: change the
`members` list in `peribolos.yaml` to add or remove reviewers.

GitHub CODEOWNERS cannot filter on milestones, so assignment is done by
the org-infra workflow **Assign Evidence Locker MVP Reviewers** (see
`docs/MILESTONE_REVIEWERS.md` in `complytime/org-infra`). Native GitHub
code review auto-assignment is not used for this team.

### Add a New Repository to Safe-settings Management

1. Add the repo to `peribolos.yaml` with `description`, `has_projects`,
Expand Down
25 changes: 25 additions & 0 deletions peribolos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,3 +238,28 @@ orgs:
homebrew-tap: write
org-infra: write
website: write
evidence-locker-mvp-reviewers:
description: Reviewers automatically assigned to Evidence Locker MVP milestone items
privacy: closed
maintainers:
- gxmiranda
- jpower432
- marcusburghardt
members:
- hbraswelrh
- sedonnel
- trevor-vaughan
repos:
community: write

@trevor-vaughan trevor-vaughan Aug 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question
@beatrizmcouto Don't we need nunya in this list?

@beatrizmcouto beatrizmcouto Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes — good catch. The Evidence Locker MVP milestone lives on nunya, so this team needs that repo or GitHub cannot request these people as reviewers there.

Added nunya: maintain in 69c917f (maintain so members can create sub-issues; GitHub hides that for Read). The secret nunya-access team stays unmanaged by Peribolos (--ignore-secret-teams).

Note: #205 (nunya on complytime-dev) was closed because @jpower432 is handling that access another way. This team still needs the grant because assignment for this milestone is on nunya.

complyapi: write
complyctl: write
complypack: write
complyscribe: write
complytime: write
complytime-collector-components: write
complytime-demos: write
complytime-policies: write
complytime-providers: write
homebrew-tap: write
org-infra: write
website: write
Loading