This repository was archived by the owner on Aug 5, 2026. It is now read-only.
clingwrapper: expose AddTypeQualifier. - #209
Open
vgvassilev wants to merge 1 commit into
Open
Conversation
The cv-qualifier triplet was already in CppInterOp's public surface
(Cpp::AddTypeQualifier etc., declared by the tablegen-generated
CppInterOpDecl.inc) but the cppyy-backend shim didn't re-export them
as Cppyy:: wrappers. Adding "const" to a TCppType_t -- e.g. building
"const T" out of GetType("T") for the canonical-QT registry in
Converters.cxx -- required pulling in CppInterOp.h directly, which
breaks the cppyy-backend abstraction boundary.
Add the Cppyy::AddTypeQualifier wrapper in cpp_cppyy.h +
clingwrapper.cxx, mirroring the GetPointerType / GetReferencedType
pattern (one-line forwarder under InterOpMutex). Only AddTypeQualifier
has an in-tree caller (Converters.cxx); RemoveTypeQualifier and
HasTypeQualifier are left out until a concrete caller appears -- the
canonical-QT identity check is already handled by direct pointer
comparison.
vgvassilev
force-pushed
the
move-from-container
branch
from
June 5, 2026 14:38
9edafb9 to
04eeeb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cv-qualifier triplet was already in CppInterOp's public surface (Cpp::AddTypeQualifier etc., declared by the tablegen-generated CppInterOpDecl.inc) but the cppyy-backend shim didn't re-export them as Cppyy:: wrappers. Adding "const" to a TCppType_t -- e.g. building "const T" out of GetType("T") for the canonical-QT registry in Converters.cxx -- required pulling in CppInterOp.h directly, which breaks the cppyy-backend abstraction boundary.
Add the Cppyy::AddTypeQualifier wrapper in cpp_cppyy.h + clingwrapper.cxx, mirroring the GetPointerType / GetReferencedType pattern (one-line forwarder under InterOpMutex). Only AddTypeQualifier has an in-tree caller (Converters.cxx); RemoveTypeQualifier and HasTypeQualifier are left out until a concrete caller appears -- the canonical-QT identity check is already handled by direct pointer comparison.