Repository navigation
Drop cppjit_backend and unify with cpyrt - #42
Merged
Merged
Conversation
Test Results
|
vgvassilev
approved these changes
Aug 26, 2026
vgvassilev
left a comment
vgvassilev
left a comment
Contributor
There was a problem hiding this comment.
Lgtm! Consider either splitting into two PRs or making once commit with the appropriate commit message.
aaronj0
force-pushed
the
single-interop-header
branch
from
August 26, 2026 14:09
7e3bad4 to
2a3a417
Compare
vgvassilev
pushed a commit
to vgvassilev/cppjit
that referenced
this pull request
Sep 6, 2026
…rch#42) Fixes the long-standing header duplication (previously `Cppyy.h` and `cpp_cppyy.h`) between cpyrt and interop, so that there is only a single source of definitions for the `cppjit::interop` API and types.
aaronj0
added a commit
to aaronj0/cppjit-compres
that referenced
this pull request
Sep 6, 2026
…rch#42) Fixes the long-standing header duplication (previously `Cppyy.h` and `cpp_cppyy.h`) between cpyrt and interop, so that there is only a single source of definitions for the `cppjit::interop` API and types.
aaronj0
added a commit
to aaronj0/cppjit-compres
that referenced
this pull request
Sep 6, 2026
…rch#42) Fixes the long-standing header duplication (previously `Cppyy.h` and `cpp_cppyy.h`) between cpyrt and interop, so that there is only a single source of definitions for the `cppjit::interop` API and types.
aaronj0
added a commit
to aaronj0/cppjit-compres
that referenced
this pull request
Sep 6, 2026
…rch#42) Fixes the long-standing header duplication (previously `Cppyy.h` and `cpp_cppyy.h`) between cpyrt and interop, so that there is only a single source of definitions for the `cppjit::interop` API and types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unifies our installation layout under a single cppjit module, dropping the concept of a separate
cppjit_backend, making our wheel package count 1. As a part of this change, I have dropped the long-standing header duplication (previouslyCppyy.handcpp_cppyy.h) between cpyrt and interop, so that there is only a single source of definitions for thecppjit::interopAPI and types.