[python][win] use .dll for shared lib test, catch error for win32 workaround

[aaronj0]

No description provided.

[guitargeek]

Since you're already fixing for different shared object extensions, this should be done consistently in the other places that hardcode .so as well.

So I'd suggest complementing the PR with this patch:

diff --git a/test/Makefile b/test/Makefile
index 7f1433e..7c89130 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -1,6 +1,11 @@
 # the C++ sides of the tests live under cpp/ and build into shared
 # libraries next to their sources (load_reflection_info resolves the
-# header as a sibling of the loaded Dict.so)
+# header as a sibling of the loaded Dict library)
+soext = .so
+ifeq ($(OS),Windows_NT)
+  soext = .dll
+endif
+
 dictnames = advancedcpp \
             advancedcpp2 \
             conversions \
@@ -17,7 +22,7 @@ dictnames = advancedcpp \
             stltypes \
             templates

-dicts = $(addprefix cpp/,$(addsuffix Dict.so,$(dictnames)))
+dicts = $(addprefix cpp/,$(addsuffix Dict$(soext),$(dictnames)))

 all : $(dicts)

@@ -30,11 +35,11 @@ ifeq ($(PLATFORM),Darwin)
 endif

 # a worker can load the library while another rebuilds it, so publish it whole
-cpp/%Dict.so: cpp/%.cxx cpp/%.h
+cpp/%Dict$(soext): cpp/%.cxx cpp/%.h
        $(CXX) $(cppflags) -shared -o $@.$$$$.tmp $< && mv -f $@.$$$$.tmp $@

diff --git a/test/Makefile b/test/Makefile
index 7f1433e..7c89130 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -1,6 +1,11 @@
 # the C++ sides of the tests live under cpp/ and build into shared
 # libraries next to their sources (load_reflection_info resolves the
-# header as a sibling of the loaded Dict.so)
+# header as a sibling of the loaded Dict library)
+soext = .so
+ifeq ($(OS),Windows_NT)
+  soext = .dll
+endif
+
 dictnames = advancedcpp \
             advancedcpp2 \
             conversions \
@@ -17,7 +22,7 @@ dictnames = advancedcpp \
             stltypes \
             templates

-dicts = $(addprefix cpp/,$(addsuffix Dict.so,$(dictnames)))
+dicts = $(addprefix cpp/,$(addsuffix Dict$(soext),$(dictnames)))

 all : $(dicts)

@@ -30,11 +35,11 @@ ifeq ($(PLATFORM),Darwin)
 endif

 # a worker can load the library while another rebuilds it, so publish it whole
-cpp/%Dict.so: cpp/%.cxx cpp/%.h
+cpp/%Dict$(soext): cpp/%.cxx cpp/%.h
        $(CXX) $(cppflags) -shared -o $@.$$$$.tmp $< && mv -f $@.$$$$.tmp $@

-# convenience: `make datatypesDict.so` builds cpp/datatypesDict.so
-%Dict.so: cpp/%Dict.so ;
+# convenience: `make datatypesDict$(soext)` builds cpp/datatypesDict$(soext)
+%Dict$(soext): cpp/%Dict$(soext) ;

 .PHONY: test clean

diff --git a/test/support.py b/test/support.py
index 91fab8e..94c4738 100644
--- a/test/support.py
+++ b/test/support.py
@@ -45,7 +45,7 @@ def setup_make(targetname, optional=False):
         if fcntl is not None:
             fcntl.flock(lockf, fcntl.LOCK_EX)
         popen = subprocess.Popen(
-            ["make", targetname + "Dict.so"],
+            ["make", targetname + "Dict" + soext],
             cwd=str(currpath),
             stdout=subprocess.PIPE,
             stderr=subprocess.STDOUT,

[guitargeek]

LGTM! Thanks for these Windows fixes