Skip to content

Emit discardable-ODR variables via odr-use instead of UsedAttr in GetVariableOffset - #1068

Merged
vgvassilev merged 2 commits into
compiler-research:mainfrom
conrade-ctc:odruse-instead-of-usedattr-in-getvariableoffset
Aug 27, 2026
Merged

Emit discardable-ODR variables via odr-use instead of UsedAttr in GetVariableOffset#1068
vgvassilev merged 2 commits into
compiler-research:mainfrom
conrade-ctc:odruse-instead-of-usedattr-in-getvariableoffset

test: skip the unmaterializable-definition case out-of-process

0070564
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 27, 2026 in 1s

87.72% (+0.03%) compared to 1795887

View this Pull Request on Codecov

87.72% (+0.03%) compared to 1795887

Details

Codecov Report

❌ Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.72%. Comparing base (1795887) to head (0070564).

Files with missing lines Patch % Lines
lib/CppInterOp/CppInterOp.cpp 91.42% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
+ Coverage   87.68%   87.72%   +0.03%     
==========================================
  Files          23       23              
  Lines        6382     6418      +36     
==========================================
+ Hits         5596     5630      +34     
- Misses        786      788       +2     
Files with missing lines Coverage Δ
lib/CppInterOp/InterpreterInfo.h 100.00% <100.00%> (ø)
lib/CppInterOp/CppInterOp.cpp 90.52% <91.42%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
lib/CppInterOp/InterpreterInfo.h 100.00% <100.00%> (ø)
lib/CppInterOp/CppInterOp.cpp 90.52% <91.42%> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.