[examples/reshare] Use glue::dkg#4146
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 5a1121d | Jul 17 2026, 04:43 PM |
Deploying monorepo with
|
| Latest commit: |
5a1121d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://510cbff3.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://cl-reshare-glue.monorepo-eu0.pages.dev |
cf8c4a5 to
f74963e
Compare
a4c3081 to
c991ee4
Compare
62b5e97 to
9d409a6
Compare
dca98a6 to
e27cc69
Compare
8ba0347 to
6b26acc
Compare
2b657bf to
7d99583
Compare
a24da3e to
4a40524
Compare
e822aaa to
c595e3e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Benchmark resultsRegressions: ✅ `qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true` (2/2 gates passed)
✅ `qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true` (2/2 gates passed)
Baseline commit(s): |
47eee54 to
0d5f422
Compare
33047bd to
f1f1eb5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cl/glue-reshare #4146 +/- ##
===================================================
- Coverage 95.04% 95.03% -0.01%
===================================================
Files 595 595
Lines 243142 243143 +1
Branches 5956 5956
===================================================
- Hits 231089 231078 -11
- Misses 10066 10078 +12
Partials 1987 1987 see 9 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
examples/reshare: support DKG setup mode examples/reshare: finish DKG bootstrap handoff
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5a1121d. Configure here.
| network.participants[0].clone(), | ||
| genesis_info.clone(), | ||
| genesis_state_root, | ||
| ); |
There was a problem hiding this comment.
Genesis root uses live QMDB
Medium Severity
On each validator start, empty_db_root opens the persisted validator-* QMDB and uses its current merkle root as the height-0 state_root in Block::genesis. That root is only correct for a brand-new database; after any prior run it reflects applied state, not the canonical empty genesis commitment (fixed range at height zero). If marshal is reset while runtime/ remains, startup can anchor to a genesis block that does not match the chain or peer state, breaking verification and stateful reconciliation.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 5a1121d. Configure here.
2 participants
Overview
Note
PR Stack:
glue::dkg#4146 👈mainPorts
examples/reshareto useglue::dkg.