Skip to content

[glue] DKG+reshare#4131

Open
clabby wants to merge 1 commit into
mainfrom
cl/glue-reshare
Open

[glue] DKG+reshare#4131
clabby wants to merge 1 commit into
mainfrom
cl/glue-reshare

Conversation

@clabby

@clabby clabby commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Overview

Adds a standard, state-sync capable DKG+reshare library to commonware-glue. Protocol explained in the docs.

closes #3921

@clabby clabby self-assigned this Jun 29, 2026
@clabby clabby added this to Tracker Jun 29, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 29, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 282a13e Jul 15 2026, 02:35 PM

@clabby clabby force-pushed the cl/glue-reshare branch from a9dcb65 to 85d40dc Compare June 29, 2026 15:06
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 29, 2026

Copy link
Copy Markdown

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 282a13e
Status: ✅  Deploy successful!
Preview URL: https://65fbed88.monorepo-eu0.pages.dev
Branch Preview URL: https://cl-glue-reshare.monorepo-eu0.pages.dev

View logs

@clabby clabby moved this to In Progress in Tracker Jun 29, 2026
@clabby clabby force-pushed the cl/glue-reshare branch 4 times, most recently from 859c8d8 to fb8dd9d Compare June 29, 2026 17:55
@clabby clabby changed the base branch from main to cl/reshare-nits June 29, 2026 17:56
@clabby clabby force-pushed the cl/glue-reshare branch from fb8dd9d to 926a5d7 Compare June 29, 2026 18:00
@clabby clabby force-pushed the cl/reshare-nits branch from fccf1e3 to 71d47dc Compare June 29, 2026 18:02
@clabby clabby force-pushed the cl/glue-reshare branch 2 times, most recently from d21cf0f to 207b02f Compare June 29, 2026 18:27
@clabby clabby force-pushed the cl/reshare-nits branch from 42b1a4b to 65b0ea7 Compare June 29, 2026 18:28
@clabby clabby force-pushed the cl/glue-reshare branch from 207b02f to 7781b51 Compare June 29, 2026 18:28
@clabby clabby force-pushed the cl/reshare-nits branch from 65b0ea7 to 6226e40 Compare June 29, 2026 18:29
@clabby clabby force-pushed the cl/glue-reshare branch from 7781b51 to b7f9e1d Compare June 29, 2026 18:29
@clabby clabby force-pushed the cl/reshare-nits branch from 6226e40 to ae6b587 Compare June 29, 2026 18:45
@clabby clabby force-pushed the cl/glue-reshare branch 2 times, most recently from 9e5d2c3 to 647b9b5 Compare June 29, 2026 20:54
Base automatically changed from cl/reshare-nits to main June 29, 2026 21:32
@clabby clabby force-pushed the cl/glue-reshare branch 2 times, most recently from 3708d04 to dbfddd4 Compare June 30, 2026 18:46
@commonwarexyz commonwarexyz deleted a comment from github-actions Bot Jul 1, 2026
@clabby clabby marked this pull request as ready for review July 1, 2026 22:05
Comment thread glue/src/dkg/orchestrator/actor.rs
Comment thread glue/src/dkg/reshare/actor/setup.rs Outdated
@clabby clabby force-pushed the cl/glue-reshare branch from c05cd9d to c5968fd Compare July 1, 2026 22:18
@clabby clabby moved this from In Progress to Ready for Review in Tracker Jul 1, 2026
@clabby clabby force-pushed the cl/glue-reshare branch from d88a166 to e679b77 Compare July 2, 2026 05:07
Comment thread glue/src/dkg/bootstrap/mod.rs
@clabby clabby force-pushed the cl/glue-reshare branch 4 times, most recently from 8332c93 to d05a766 Compare July 6, 2026 16:35
Comment thread glue/src/dkg/reshare/actor/follower.rs
@clabby clabby force-pushed the cl/glue-reshare branch from 2dc5f83 to 95f08d3 Compare July 6, 2026 17:07
Comment thread glue/src/dkg/reshare/application.rs
@clabby clabby force-pushed the cl/glue-reshare branch 8 times, most recently from 0339966 to 375983d Compare July 10, 2026 02:00
@patrick-ogrady patrick-ogrady added this to the v2026.8.0 milestone Jul 10, 2026
@clabby clabby force-pushed the cl/glue-reshare branch from 375983d to 6585dd8 Compare July 12, 2026 16:22
@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown

Benchmark results

Regressions: 0.

✅ `qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true` (2/2 gates passed)
Field Value
Package commonware-storage
Benchmark target qmdb_gungraun
Variant qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true
Filter *::bench_merkleize::any_unordered_fixed_mmr
Baseline suite commonware-storage
Gates EstimatedCycles should decrease; tolerance 10.00%; blob_reads should decrease; tolerance 10.00%
Cargo flags --features test-traits
Metric Baseline Current Delta Gate
Ir 13,377,341 13,372,424 -0.04% -
L1hits 17,203,398 17,196,686 -0.04% -
LLhits 98,526 97,909 -0.63% -
RamHits 9,998 10,099 +1.01% -
TotalRW 17,311,922 17,304,694 -0.04% -
EstimatedCycles 18,045,958 18,039,696 -0.03% EstimatedCycles should decrease; tolerance 10.00%
blob_reads 158 158 +0.00% blob_reads should decrease; tolerance 10.00%
✅ `qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true` (2/2 gates passed)
Field Value
Package commonware-storage
Benchmark target qmdb_gungraun
Variant qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true
Filter *::bench_merkleize::current_ordered_fixed_mmb_chunk_256
Baseline suite commonware-storage
Gates EstimatedCycles should decrease; tolerance 10.00%; blob_reads should decrease; tolerance 10.00%
Cargo flags --features test-traits
Metric Baseline Current Delta Gate
Ir 15,950,249 16,027,718 +0.49% -
L1hits 21,022,705 21,235,255 +1.01% -
LLhits 143,053 144,063 +0.71% -
RamHits 12,456 12,449 -0.06% -
TotalRW 21,178,214 21,391,767 +1.01% -
EstimatedCycles 22,173,930 22,391,285 +0.98% EstimatedCycles should decrease; tolerance 10.00%
blob_reads 235 235 +0.00% blob_reads should decrease; tolerance 10.00%

Baseline commit(s): 5950bf7179bb

@clabby clabby force-pushed the cl/glue-reshare branch 3 times, most recently from f1f1eb5 to eea9175 Compare July 14, 2026 21:04

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit eea9175. Configure here.

Comment thread glue/src/dkg/reshare/actor/setup.rs
@clabby clabby force-pushed the cl/glue-reshare branch 2 times, most recently from c34240e to 7c84da4 Compare July 15, 2026 02:37
@clabby clabby force-pushed the cl/glue-reshare branch from 7c84da4 to 282a13e Compare July 15, 2026 14:34
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.25144% with 381 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.01%. Comparing base (5950bf7) to head (282a13e).

Files with missing lines Patch % Lines
glue/src/dkg/anchor/actor/discovery.rs 76.35% 34 Missing and 14 partials ⚠️
glue/src/dkg/reshare/actor/dkg.rs 67.64% 38 Missing and 6 partials ⚠️
glue/src/dkg/reshare/actor/inclusion.rs 88.67% 26 Missing and 16 partials ⚠️
glue/src/dkg/reshare/actor/dealing.rs 76.39% 30 Missing and 8 partials ⚠️
glue/src/dkg/types.rs 81.76% 24 Missing and 5 partials ⚠️
glue/src/dkg/reshare/store.rs 96.49% 15 Missing and 10 partials ⚠️
glue/src/dkg/reshare/mailbox.rs 73.41% 20 Missing and 1 partial ⚠️
glue/src/dkg/anchor/actor/serving.rs 59.57% 17 Missing and 2 partials ⚠️
glue/src/dkg/orchestrator/actor.rs 94.53% 10 Missing and 6 partials ⚠️
glue/src/dkg/reshare/actor/follower.rs 73.68% 13 Missing and 2 partials ⚠️
... and 15 more
@@            Coverage Diff             @@
##             main    #4131      +/-   ##
==========================================
- Coverage   95.04%   95.01%   -0.03%     
==========================================
  Files         573      595      +22     
  Lines      238692   242973    +4281     
  Branches     5802     5953     +151     
==========================================
+ Hits       226862   230865    +4003     
- Misses       9920    10125     +205     
- Partials     1910     1983      +73     
Files with missing lines Coverage Δ
consensus/src/lib.rs 100.00% <ø> (+78.57%) ⬆️
consensus/src/marshal/coding/marshaled.rs 85.56% <100.00%> (+0.03%) ⬆️
consensus/src/marshal/standard/deferred.rs 96.31% <100.00%> (+0.12%) ⬆️
consensus/src/types.rs 95.62% <100.00%> (+0.01%) ⬆️
glue/src/dkg/fence.rs 100.00% <100.00%> (ø)
glue/src/dkg/reshare/application.rs 100.00% <100.00%> (ø)
glue/src/simulate/action.rs 85.00% <ø> (ø)
glue/src/simulate/plan.rs 88.09% <100.00%> (+0.61%) ⬆️
glue/src/simulate/reporter.rs 100.00% <100.00%> (ø)
glue/src/stateful/actor/core/mailbox.rs 74.50% <100.00%> (+0.50%) ⬆️
... and 33 more

... and 30 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5950bf7...282a13e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

[glue] Add standard DKG/reshare

2 participants