[BMU-2743] Upgrade jsondiffpatch - Security Vulnerability - #60
Merged
Conversation
marcelogpinheiro
marked this pull request as draft
June 30, 2026 10:34
Contributor
Author
|
I'm checking the pipeline tests... |
🦋 Changeset detectedLatest commit: cc3b3cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marcelogpinheiro
marked this pull request as ready for review
June 30, 2026 11:10
marcelogpinheiro
marked this pull request as draft
June 30, 2026 11:15
marcelogpinheiro
marked this pull request as ready for review
June 30, 2026 11:20
islam3zzat
approved these changes
Jun 30, 2026
islam3zzat
left a comment
Contributor
There was a problem hiding this comment.
Thank you, could we remove the code comments that are related to this upgrade.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade jsondiffpatch from 0.5.0 to 0.7.6
Bumps
jsondiffpatchinpackages/sync-actionsfrom0.5.0to^0.7.6to fix security vulnerabilities in 0.5.0.Why the config changes were needed
0.7 is ESM-only with breaking API changes, so a few adjustments were required:
jest.config.js(root) +packages/sync-actions/jest.config.js— Jest skipsnode_modulesby default, so the ESM package threwCannot use import statement outside a module. AddedtransformIgnorePatterns: ['/node_modules/(?!(jsondiffpatch)/)']to transpile it. The root config is the one CI uses.package.json(root) — bumpedtypescript^4.6.2→^5.8.2, required by 0.7's type definitions.src/utils/diffpatcher.ts— new import path (jsondiffpatch); droppedtextDiff.minLength(text diffing is opt-in in 0.7, and whole-value replacement is what we want);patch()now returnsunknown, narrowed back toT.src/utils/types.ts— replaced jsondiffpatch's strictDeltatype with a looseRecord<string | number, any>, since builders index deltas by key and position.Tests added in
test/utils/diffpatcher.spec.ts.