Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
adeebshihadeh
left a comment
Contributor
There was a problem hiding this comment.
I think we'll want to both log generic, low-level USB state and parse out our specific peripherals.
Such that consumers of this don't need to know the chestnut VID/PID, loop through the low level state, etc:
hardwareState {
....
chestnutPresent: bool;
// low level state straight from the kernel
usbState {
}
}
| "selfdrive.modeld.modeld": 22.0, | ||
| "selfdrive.modeld.dmonitoringmodeld": 18.0, | ||
| "system.hardware.hardwared": 4.0, | ||
| "system.hardware.usbd": 1.0, |
Contributor
There was a problem hiding this comment.
i think this just goes in hardwared
Contributor
Author
There was a problem hiding this comment.
I thought about 100Hz+ usb state sampling inside usbd to catch transients but could do that in the kernel with interrupts and sample only the resulting counters in hardwared with 2Hz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic USB logging.
TODO: