perf: benchmark numeric stdlib - #59
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands benchmark coverage for the RFC 0113 numeric standard library by defining RFC 0116 and adding four matching workloads to both qbench and cargo bench --bench core, with accompanying CLI guard assertions and performance documentation updates.
Changes:
- Added
stdlib-abs,stdlib-sum,stdlib-min-max, andstdlib-range-sumworkloads toqbenchand thecorebench runner. - Extended the CLI test that validates machine-readable
qbench --jsonworkload enumeration (and--listoutput). - Documented the new workloads, reproducibility commands, and sample measurements; updated RFC scope references.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/cli_tools.rs | Extends the expected qbench workload name list to include the four new stdlib workloads. |
| src/bin/qbench.rs | Adds four numeric stdlib workloads to the qbench workload registry with expected values. |
| benches/core.rs | Adds the same four workloads to cargo bench --bench core, including iteration counts. |
| RFCs/0116-stdlib-benchmark-coverage.md | Introduces RFC 0116 specifying benchmark coverage/acceptance criteria for numeric stdlib workloads. |
| RFCs/0000-project-scope.md | Updates the “implemented RFCs” upper bound to RFC 0116. |
| README.md | Updates the documented RFC coverage range to include RFC 0116. |
| PERFORMANCE.md | Documents the new workloads, reproduction commands, and records sample benchmark results. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tiye
force-pushed
the
feat/qtest-selection
branch
from
August 22, 2026 17:45
3953914 to
a0f92c4
Compare
tiye
force-pushed
the
perf/stdlib-benchmarks
branch
from
August 22, 2026 17:46
b9240d6 to
1e7326e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stdlib-abs,stdlib-sum,stdlib-min-max, andstdlib-range-sumto qbench andcargo bench --bench corePERFORMANCE.mdValidation
cargo run --locked --release --bin qbench -- --json --iterations 1 --repeat 1cargo bench --locked --bench coremake checkThis PR is stacked on PR #58 and is intentionally not merged independently.