perf: guard the complete core benchmark suite - #51
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Expands qbench’s release/CI semantic guard from a small subset to the full core benchmark workload suite, and codifies the requirement via a new RFC so future core benchmarks can’t drift from qbench --json coverage.
Changes:
- Add RFC 0109 requiring 1:1 coverage between
cargo bench --bench coreworkloads andqbench --jsonbuilt-ins. - Expand
qbench’s built-inWORKLOADSset to the complete 34-workload core suite. - Strengthen the CLI integration test to assert every stable workload name appears exactly once and that timing/schema fields are present.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cli_tools.rs | Expands the qbench --json integration assertions to cover all 34 workload names and required fields. |
| src/bin/qbench.rs | Adds the missing core workloads to qbench so CI/release gating exercises the full suite. |
| RFCs/0109-qbench-core-suite.md | Defines the coverage and output-contract guardrails for the full core suite in qbench. |
| RFCs/0000-project-scope.md | Updates the repository’s implemented RFC range and list to include RFC 0109. |
| README.md | Updates the documented RFC range link to point through RFC 0109. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo run --locked --quiet --release --bin qbench -- --json --iterations 1 --repeat 3make checkgit diff --checkThis PR is stacked on PR #50 and should remain unmerged with the existing chain.