Skip to content

perf: guard the complete core benchmark suite - #51

Merged
tiye merged 1 commit into
test/qtest-showcase-corpusfrom
perf/qbench-core-suite
Aug 22, 2026
Merged

perf: guard the complete core benchmark suite#51
tiye merged 1 commit into
test/qtest-showcase-corpusfrom
perf/qbench-core-suite

Conversation

@tiye

@tiye tiye commented Aug 22, 2026

Copy link
Copy Markdown
Member

Summary

  • add RFC 0109 requiring qbench coverage for every core benchmark workload
  • expand release qbench from six to the complete 34-workload core suite
  • assert every stable workload name and timing field in the CLI integration test

Validation

  • cargo run --locked --quiet --release --bin qbench -- --json --iterations 1 --repeat 3
  • make check
  • git diff --check

This PR is stacked on PR #50 and should remain unmerged with the existing chain.

Copilot AI lite review requested due to automatic review settings August 22, 2026 16:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands qbench’s release/CI semantic guard from a small subset to the full core benchmark workload suite, and codifies the requirement via a new RFC so future core benchmarks can’t drift from qbench --json coverage.

Changes:

  • Add RFC 0109 requiring 1:1 coverage between cargo bench --bench core workloads and qbench --json built-ins.
  • Expand qbench’s built-in WORKLOADS set to the complete 34-workload core suite.
  • Strengthen the CLI integration test to assert every stable workload name appears exactly once and that timing/schema fields are present.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/cli_tools.rs Expands the qbench --json integration assertions to cover all 34 workload names and required fields.
src/bin/qbench.rs Adds the missing core workloads to qbench so CI/release gating exercises the full suite.
RFCs/0109-qbench-core-suite.md Defines the coverage and output-contract guardrails for the full core suite in qbench.
RFCs/0000-project-scope.md Updates the repository’s implemented RFC range and list to include RFC 0109.
README.md Updates the documented RFC range link to point through RFC 0109.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@tiye
tiye merged commit 802278c into test/qtest-showcase-corpus Aug 22, 2026
3 checks passed
@tiye
tiye deleted the perf/qbench-core-suite branch August 22, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants