perf: cover signed by in core benchmark - #40
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the signed-step workload to the core benchmark suite and records its timing sample.
Changes:
- Adds
signed-by-iterationwith expected value3333. - Documents core benchmark results in
PERFORMANCE.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Summary | Review comment |
|---|---|---|
PERFORMANCE.md |
Records benchmark timing data. | Nit: Align the documented iteration counts for consistency. |
benches/core.rs |
Adds the signed-step workload and semantic guard. | — |
Suppressed comments (1)
PERFORMANCE.md:548
- This adds only a single core-benchmark reading, while the report's current baseline/raw-sample sections still omit
signed-by-iterationand explicitly require three release runs with a median for benchmark evidence (PERFORMANCE.md:493-534; RFCs/0045-semantic-benchmark-guards.md:6-8). Please either add this workload to the same three-run median tables, or clearly label this as a non-baseline validation sample like the preceding qbench entry so it is not presented as comparable core-benchmark data.
标准 `cargo bench --locked --bench core`(10,000 次)同样已纳入该负载;本次样本为编译 `38.544 ms`、验证 `2.032 ms`、执行 `157.776 ms`,期望值 `3333`。它与正向 `stepped-iteration` 的执行样本(`124.616 ms`)同场输出,便于观察有符号步进的额外边界检查成本。
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tiye
force-pushed
the
perf/rfc0100-report
branch
from
August 23, 2026 04:47
1238586 to
207fde1
Compare
Base automatically changed from
perf/rfc0100-report
to
feat/program-fingerprint
August 23, 2026 04:48
tiye
force-pushed
the
perf/core-rfc0100-workload
branch
from
August 23, 2026 04:50
0c1c326 to
5facc10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signed-by-iterationto the standardcargo bench --bench coresuite3333PERFORMANCE.mdValidation
cargo bench --locked --bench coremake checkgit diff --checkThis PR is chained after PR #39 and is intentionally not merged automatically.