Skip to content

perf: cover signed by in core benchmark - #40

Merged
tiye merged 2 commits into
feat/program-fingerprintfrom
perf/core-rfc0100-workload
Aug 23, 2026
Merged

perf: cover signed by in core benchmark#40
tiye merged 2 commits into
feat/program-fingerprintfrom
perf/core-rfc0100-workload

Conversation

@tiye

@tiye tiye commented Aug 22, 2026

Copy link
Copy Markdown
Member

Summary

  • add signed-by-iteration to the standard cargo bench --bench core suite
  • keep a runtime semantic guard for expected value 3333
  • record a core-benchmark sample alongside the qbench sample in PERFORMANCE.md

Validation

  • cargo bench --locked --bench core
  • make check
  • git diff --check

This PR is chained after PR #39 and is intentionally not merged automatically.

Copilot AI lite review requested due to automatic review settings August 22, 2026 15:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the signed-step workload to the core benchmark suite and records its timing sample.

Changes:

  • Adds signed-by-iteration with expected value 3333.
  • Documents core benchmark results in PERFORMANCE.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Summary Review comment
PERFORMANCE.md Records benchmark timing data. Nit: Align the documented iteration counts for consistency.
benches/core.rs Adds the signed-step workload and semantic guard.
Suppressed comments (1)

PERFORMANCE.md:548

  • This adds only a single core-benchmark reading, while the report's current baseline/raw-sample sections still omit signed-by-iteration and explicitly require three release runs with a median for benchmark evidence (PERFORMANCE.md:493-534; RFCs/0045-semantic-benchmark-guards.md:6-8). Please either add this workload to the same three-run median tables, or clearly label this as a non-baseline validation sample like the preceding qbench entry so it is not presented as comparable core-benchmark data.
标准 `cargo bench --locked --bench core`(10,000 次)同样已纳入该负载;本次样本为编译 `38.544 ms`、验证 `2.032 ms`、执行 `157.776 ms`,期望值 `3333`。它与正向 `stepped-iteration` 的执行样本(`124.616 ms`)同场输出,便于观察有符号步进的额外边界检查成本。

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread PERFORMANCE.md
@tiye
tiye force-pushed the perf/rfc0100-report branch from 1238586 to 207fde1 Compare August 23, 2026 04:47
Base automatically changed from perf/rfc0100-report to feat/program-fingerprint August 23, 2026 04:48
@tiye
tiye force-pushed the perf/core-rfc0100-workload branch from 0c1c326 to 5facc10 Compare August 23, 2026 04:50
@tiye
tiye merged commit ad32c9a into feat/program-fingerprint Aug 23, 2026
2 checks passed
@tiye
tiye deleted the perf/core-rfc0100-workload branch August 23, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants