fix: make qtest multi-input order deterministic - #36
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes qtest’s handling of multiple input paths deterministic by normalizing the discovered file list (global sort + dedup), and extends TAP-related regression coverage while updating the TAP RFC to match the new contract.
Changes:
- Sort and deduplicate the aggregated set of discovered test files before execution/output.
- Extend CLI TAP regression test coverage to validate determinism with reversed/duplicate inputs.
- Update RFC 0079 to specify global sort + dedup semantics for TAP mode.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/cli_tools.rs |
Adds TAP regression assertions for deterministic ordering and dedup with multiple file inputs. |
src/bin/qtest.rs |
Globally sorts and deduplicates collected file paths to make multi-input runs deterministic. |
RFCs/0079-qtest-tap-output.md |
Updates TAP CLI contract documentation to reflect global sort + dedup behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Base automatically changed from
fix/qdocco-dynamic-fence
to
chore/rfc-adoption-gate
August 22, 2026 18:02
tiye
force-pushed
the
chore/rfc-adoption-gate
branch
2 times, most recently
from
August 22, 2026 18:54
9819c72 to
89b8fb0
Compare
Base automatically changed from
chore/rfc-adoption-gate
to
feat/signed-by-iteration
August 23, 2026 04:09
tiye
force-pushed
the
feat/signed-by-iteration
branch
from
August 23, 2026 04:35
726246c to
b5544c7
Compare
Base automatically changed from
feat/signed-by-iteration
to
feat/program-fingerprint
August 23, 2026 04:36
tiye
force-pushed
the
fix/qtest-global-order
branch
from
August 23, 2026 04:39
5899cc9 to
c23925b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qtestacross multiple inputsValidation
make checkgit diff --checkThis PR is chained after PR #35 and is intentionally not merged automatically.