Repository navigation
Conversation
The IGVM command line is intended to convey debug configuration options, so obtain the debug com port identifier from the command line instead of relying on a static configuration in the IGVM file. This eliminates one more hypervisor-specific difference from the IGVM file. If the command line is not specified (QEMU does not specify a command line), then the com port defaults to 1, which is the value that QEMU expects, thus ensuring that QEMU can get the correct behavior without requiring a command line to be specified. Signed-off-by: Jon Lange <jlange@microsoft.com>
The attestation proxy's vsock port was hardcoded, preventing multiple guests from using distinct proxy instances on the same host. Add `attestation_vsock_port()` to read an optional ATTESTATIONPORT=<port> argument from the IGVM command line, mirroring the existing CONSOLEPORT= handling. Invalid or missing values fall back to the previous default. Document the new parameter in ATTESTATION.md Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1164