Repository navigation
cargo: fix up feature and remove unused dependency - #1236
Merged
Merged
Conversation
luigix25
requested review from
00xc,
joergroedel,
msft-jlange,
peterfang and
stefano-garzarella
as code owners
September 29, 2026 15:17
stefano-garzarella
added
the
in-review
luigix25
force-pushed
the
fix_cargo
branch
3 times, most recently
from
September 30, 2026 16:05
2631d24 to
b3c6e94
Compare
00xc
previously approved these changes
Oct 7, 2026
stefano-garzarella
left a comment
stefano-garzarella
left a comment
Member
There was a problem hiding this comment.
Some minor comments, but overall LGTM.
virtio-drivers is currently the only transport for the `block` and `vsock` features. Make `block` and `vsock` depend on `virtio-drivers`. Gating on `virtio-drivers` separately is now redundant, so drop it from `persistence`, the cfgs, FEATURES_TEST and update the docs accordingly. Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
The crate uses the compiler-provided proc_macro, not proc-macro2. Remove it. Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
Collaborator
Author
|
stefano-garzarella
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verus_stub