Updating the TICL offline NanoAOD

[Moanwar]

This PR adds more information to the offline TICL NanoAOD, with features aimed at improving TICL performance studies, especially for general tracks and GSF tracks for PF interpretation.
It also adds:

• GEN information for SIM-vs-GEN validation.
• The indices of the tracksters forming each TICLCandidate. This vector was already declared but not filled, so it is now properly filled and stored in the NanoAOD.
• A flag indicating whether a SimCandidate originates from PU (1) or not (0). This is normally 0 unless SIM from PU is enabled, in which case the flag becomes useful.

The PR has been tested with the relevant workflows and runs smoothly for 34506.213 and 34706.213.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51725/50651

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DPGAnalysis/HGCalNanoAOD/plugins/SimTracksterTableProducer.cc modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
  • File RecoHGCal/TICL/interface/TICLInterpretationAlgoBase.h modified in PR(s): Add directories for TICL-EGM code development #48319
  • File RecoHGCal/TICL/plugins/GNNInterpretationAlgo.cc modified in PR(s): move HGCAL configuration parameters from double to float  #51413
  • File RecoHGCal/TICL/plugins/GeneralInterpretationAlgo.cc modified in PR(s): move HGCAL configuration parameters from double to float  #51413
  • File RecoHGCal/TICL/plugins/TICLCandidateProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319, move HGCAL configuration parameters from double to float  #51413

[cmsbuild]

A new Pull Request was created by @Moanwar for master.

It involves the following packages:

• DPGAnalysis/HGCalNanoAOD (xpog)
• RecoHGCal/TICL (reconstruction)

@Moanwar, @battibass, @cmsbuild, @ftorrresd, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@apsallid, @denizsun, @felicepantaleo, @hatakeyamak, @lecriste, @mmusich, @rovere, @salimcerci, @sameasy, @sobhatta this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[Moanwar]

test parameters:

• workflow_opts = -w upgrade
• workflows = 34506.213,34706.213

[Moanwar]

@cmsbuild please test

[mmusich]

This PR adds more information to the offline TICL NanoAOD,

does it make sense to add this also in the HLT nano?

[Moanwar]

This PR adds more information to the offline TICL NanoAOD,

does it make sense to add this also in the HLT nano?

Sure, that’s indeed the plan. I started with the offline workflow and will propagate these changes to HLT as well. The HLT NanoAOD already contains some of these branches, such as GEN information and general tracks, but I’ll make the corresponding updates there too.

[cmsbuild]

-1

Failed Tests: RelVals-AMD_MI300X
Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6003e5/55446/summary.html
COMMIT: c87ee4c
CMSSW: CMSSW_20_1_X_2026-08-18-1100/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51725/55446/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Failed RelVals-AMD_MI300X

• 37634.40437634.404_TTbar_14TeV+Run4D127_Patatrack_PixelOnlyAlpaka_Profiling/step2_TTbar_14TeV+Run4D127_Patatrack_PixelOnlyAlpaka_Profiling.log
• 37634.750337634.7503_TTbar_14TeV+Run4D127_HLTHeterogeneousValid/step2_TTbar_14TeV+Run4D127_HLTHeterogeneousValid.log

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3904949
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3904923
• DQMHistoTests: Total skipped: 18
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.062 KiB( 46 files compared)
• DQMHistoSizes: changed ( 34506.213,... ): 0.016 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 34506.213,... ): 0.016 KiB MessageLogger/Warnings
• Checked 204 log files, 173 edm output root files, 47 DQM output files
• TriggerResults: found differences in 2 / 46 workflows

NVIDIA_H100 Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 98 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 173739
• DQMHistoTests: Total failures: 8737
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 165002
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 25 log files, 20 edm output root files, 7 DQM output files
• TriggerResults: no differences found

NVIDIA_L4 Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 113 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 173739
• DQMHistoTests: Total failures: 9521
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 164218
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 25 log files, 20 edm output root files, 7 DQM output files
• TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 67 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 173739
• DQMHistoTests: Total failures: 6833
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 166906
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 25 log files, 20 edm output root files, 7 DQM output files
• TriggerResults: no differences found

NVIDIA_T4 Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 95 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 173739
• DQMHistoTests: Total failures: 9125
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 164614
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 25 log files, 20 edm output root files, 7 DQM output files
• TriggerResults: no differences found

[Moanwar]

Well, the error is not related to this PR, but I’m wondering, for my understanding, why the GPU test is enabled. Maybe I missed something, and it will be enabled by default now? @smuzaffar

[mmusich]

for my understanding, why the GPU test is enabled. Maybe I missed something, and it will be enabled by default now?

I suspect it's coming from cms-sw/cms-bot#2825, but I am not sure if any of the packages touched here qualifies?

[Moanwar]

for my understanding, why the GPU test is enabled. Maybe I missed something, and it will be enabled by default now?

I suspect it's coming from cms-sw/cms-bot#2825, but I am not sure if any of the packages touched here qualifies?

Okay, I see. Yeah, I wasn’t aware of that, thanks! All the packages here should be GPU-unrelated. Maybe @smuzaffar could cross-check?

[smuzaffar]

@Moanwar @mmusich , bot decided to enable GPU tests as it found direct cuda/rocm/alpaka dependency in one of the packages touch by this PR e.g I see in Jenkins logs

16:33:13 MSG: cuda/rocm/alapka dependency found: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_20_1_X_2026-08-18-1100/src/RecoHGCal/TICL/plugins/BuildFile.xml
16:33:13 Auto enabled GPU tests: NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4,AMD_MI300X,AMD_W7900,NVIDIA_L4

and of course there is alpaka dependency https://github.com/cms-sw/cmssw/blob/master/RecoHGCal/TICL/plugins/BuildFile.xml#L44

[mmusich]

and of course there is alpaka dependency https://github.com/cms-sw/cmssw/blob/master/RecoHGCal/TICL/plugins/BuildFile.xml#L44

In my opinion this is a bit too open. Shouldn't the bot check before if the plugin touched is actually an alpaka one or not?

[smuzaffar]

In my opinion this is a bit too open. Shouldn't the bot check before if the plugin touched is actually an alpaka one or not?

this is too fine graind detail which bot does not know at the time it has to decide it GPU tests should be enabled or not

[Moanwar]

and of course there is alpaka dependency https://github.com/cms-sw/cmssw/blob/master/RecoHGCal/TICL/plugins/BuildFile.xml#L44

In my opinion this is a bit too open. Shouldn't the bot check before if the plugin touched is actually an alpaka one or not?

In my opinion this is a bit too open. Shouldn't the bot check before if the plugin touched is actually an alpaka one or not?

this is too fine graind detail which bot does not know at the time it has to decide it GPU tests should be enabled or not

Thanks a lot @smuzaffar for checking. I see the point, but this would still lead to longer test times when the changes don’t actually need to be tested on the GPU, and could potentially trigger unrelated errors as well. Do you think there’s a way to adapt this?