METAlgorithms: Cleanup dependency to avoid linking TF for GenMETProducer - #51632
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51632/50459 |
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
please test workflow 1.0,6.0 for fc42_riscv64_gcc15 |
|
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
|
-1 Failed Tests: Build HeaderConsistency The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed BuildI found compilation error when building: >> Compiling src/PerfTools/Callgrind/test/testRunner.cpp c++ -c -DCMS_MICRO_ARCH='rv64g' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=150101 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_20_1_X_2026-07-30-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_20_1_X_2026-07-30-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/riscv64/week0/fc42_riscv64_gcc15/cms/cmssw/CMSSW_20_1_X_2026-07-30-2300/src -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/pcre/8.43-f70e79b8a64841744dd619435ec45097/include -isystem/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/boost/1.91.0-1003ab9cd1189938fa1c20d6a271113d/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/bz2lib/1.0.8-f341306a3abb7f5c173546b7bcd96f9a/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/cppunit/1.15.x-27358e8be369d16a9726043208768314/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/libuuid/2.40-5a79c0e32d3975bdf73a644b1920f83b/include -isystem/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/lcg/root/6.36.13-27e925ac99626c042de941c9e8286ee6/include -isystem/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/tbb/v2022.3.0-b299124e42e92f6c7ab1f524aba20f0c/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/xz/5.8.3-2658f17c929a8c0be86380d7bbd6beb4/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/zlib/1.3.2-212f6068bca4ce06cb20f8cf9ce4b533/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/md5/1.0.0-692bc8b651e32eccdf66dbd2306b4747/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/tinyxml2/6.2.0-58ac00da9b62cecf4898212b4da436cc/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++23 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -fsigned-char -fsigned-bitfields -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-result -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/fc42_riscv64_gcc15/src/PerfTools/Callgrind/test/testPerfToolsCallgrind/testRunner.cpp.d src/PerfTools/Callgrind/test/testRunner.cpp -o tmp/fc42_riscv64_gcc15/src/PerfTools/Callgrind/test/testPerfToolsCallgrind/testRunner.cpp.o >> Building binary testPerfToolsCallgrind c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++23 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -fsigned-char -fsigned-bitfields -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-result -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC tmp/fc42_riscv64_gcc15/src/PerfTools/Callgrind/test/testPerfToolsCallgrind/ProfilerServiceTest.cppunit.cc.o tmp/fc42_riscv64_gcc15/src/PerfTools/Callgrind/test/testPerfToolsCallgrind/testRunner.cpp.o -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -L/home/cmsbuild/scratch/jenkins/workspace/ib-run-pr-tests/CMSSW_20_1_X_2026-07-30-2300/biglib/fc42_riscv64_gcc15 -L/home/cmsbuild/scratch/jenkins/workspace/ib-run-pr-tests/CMSSW_20_1_X_2026-07-30-2300/lib/fc42_riscv64_gcc15 -L/cvmfs/cms-ib.cern.ch/sw/riscv64/week0/fc42_riscv64_gcc15/cms/cmssw/CMSSW_20_1_X_2026-07-30-2300/biglib/fc42_riscv64_gcc15 -L/cvmfs/cms-ib.cern.ch/sw/riscv64/week0/fc42_riscv64_gcc15/cms/cmssw/CMSSW_20_1_X_2026-07-30-2300/lib/fc42_riscv64_gcc15 -L/cvmfs/cms-ib.cern.ch/sw/riscv64/week0/fc42_riscv64_gcc15/cms/cmssw/CMSSW_20_1_X_2026-07-30-2300/external/fc42_riscv64_gcc15/lib -lPerfToolsCallgrind -lFWCoreServiceRegistry -lFWCoreParameterSet -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCoreAbstractServices -lFWCorePluginManager -lFWCoreReflection -lFWCoreUtilities -lCore -lboost_thread -lboost_date_time -lpcre -lbz2 -lcppunit -luuid -ltbb -llzma -lz -lcms-md5 -lcrypt -ldl -lrt -ltinyxml2 -o tmp/fc42_riscv64_gcc15/src/PerfTools/Callgrind/test/testPerfToolsCallgrind/testPerfToolsCallgrind /usr/sbin/ld.bfd: cannot find -lPerfToolsCallgrind: No such file or directory collect2: error: ld returned 1 exit status >> Deleted: tmp/fc42_riscv64_gcc15/src/PerfTools/Callgrind/test/testPerfToolsCallgrind/testPerfToolsCallgrind gmake: *** [tmp/fc42_riscv64_gcc15/src/PerfTools/Callgrind/test/testPerfToolsCallgrind/testPerfToolsCallgrind] Error 1 Entering library rule at PerfTools/Callgrind >> Compiling src/PerfTools/Callgrind/src/ProfilerService.cc c++ -c -DCMS_MICRO_ARCH='rv64g' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=150101 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_20_1_X_2026-07-30-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_20_1_X_2026-07-30-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/riscv64/week0/fc42_riscv64_gcc15/cms/cmssw/CMSSW_20_1_X_2026-07-30-2300/src -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/pcre/8.43-f70e79b8a64841744dd619435ec45097/include -isystem/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/boost/1.91.0-1003ab9cd1189938fa1c20d6a271113d/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/bz2lib/1.0.8-f341306a3abb7f5c173546b7bcd96f9a/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/libuuid/2.40-5a79c0e32d3975bdf73a644b1920f83b/include -isystem/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/lcg/root/6.36.13-27e925ac99626c042de941c9e8286ee6/include -isystem/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/tbb/v2022.3.0-b299124e42e92f6c7ab1f524aba20f0c/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/xz/5.8.3-2658f17c929a8c0be86380d7bbd6beb4/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/zlib/1.3.2-212f6068bca4ce06cb20f8cf9ce4b533/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/md5/1.0.0-692bc8b651e32eccdf66dbd2306b4747/include -I/cvmfs/cms-ib.cern.ch/sw/riscv64/nweek-02952/fc42_riscv64_gcc15/external/tinyxml2/6.2.0-58ac00da9b62cecf4898212b4da436cc/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++23 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -fsigned-char -fsigned-bitfields -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-result -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/fc42_riscv64_gcc15/src/PerfTools/Callgrind/src/PerfToolsCallgrind/ProfilerService.cc.d src/PerfTools/Callgrind/src/ProfilerService.cc -o tmp/fc42_riscv64_gcc15/src/PerfTools/Callgrind/src/PerfToolsCallgrind/ProfilerService.cc.o |
|
@cms-sw/reconstruction-l2 can you please review this. This is just a technical change ( removing unused dependency). The #51632 (comment) failures are known build issues with RISCV64 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This PR removes the unused
RecoEcal/EgammaCoreToolsdependency fromRecoMET/METAlgorithms.RecoEcal/EgammaCoreToolshas dependency on Tensorflow. This cleanup means we should be able to buildGenMETProducerplugin forRISCV64IBs.Local tests shows that workflow
1.0/step1which is failing inRISCV64IB [a] now runs fine [b][a] https://cmssdt.cern.ch/SDT/cgi-bin/logreader/fc42_riscv64_gcc15/CMSSW_20_1_X_2026-07-30-2300/pyRelValMatrixLogs/run/1.0_ProdMinBias/step1_ProdMinBias.log#/
[b]