Skip to content

Remove explicit implementation of SoAConstParametersImpl - #51528

Merged
cmsbuild merged 2 commits into
cms-sw:masterfrom
sbaldu:refactor/remove-soaconstparametersimpl
Aug 13, 2026
Merged

Remove explicit implementation of SoAConstParametersImpl#51528
cmsbuild merged 2 commits into
cms-sw:masterfrom
sbaldu:refactor/remove-soaconstparametersimpl

Conversation

@sbaldu

@sbaldu sbaldu commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This PR removes the explicit definition of the SoAConstParametersImpl struct, and redefines it through SoAParametersImpl by moving the const qualifier in the column type template parameters. This allows to remove some duplicated code in the SoACommon backend.

@Electricks94

@cmsbuild

cmsbuild commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51528/50247

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @sbaldu for master.

It involves the following packages:

  • DataFormats/SoATemplate (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel

Copy link
Copy Markdown
Contributor

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c94629/54825/summary.html
COMMIT: f5e09a5
CMSSW: CMSSW_20_1_X_2026-07-20-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51528/54825/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3548294
  • DQMHistoTests: Total failures: 17
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3548259
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@cmsbuild

cmsbuild commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51528/50410

@cmsbuild

cmsbuild commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Pull request #51528 was updated. @cmsbuild, @fwyzard, @makortel can you please check and sign again.

@fwyzard

fwyzard commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

enable gpu

@fwyzard

fwyzard commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

cmsbuild commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Pull request #51528 was updated. @cmsbuild, @fwyzard, @makortel can you please check and sign again.

@fwyzard

fwyzard commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

test parameters:

  • enable = gpu

@fwyzard

fwyzard commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

please test

@fwyzard

fwyzard commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals-AMD_MI300X
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c94629/55295/summary.html
COMMIT: 3d8917a
CMSSW: CMSSW_20_1_X_2026-08-12-1100/el9_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51528/55295/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals-AMD_MI300X

  • 37634.40337634.403_TTbar_14TeV+Run4D127_Patatrack_PixelOnlyAlpaka_Validation/step2_TTbar_14TeV+Run4D127_Patatrack_PixelOnlyAlpaka_Validation.log
  • 37634.750337634.7503_TTbar_14TeV+Run4D127_HLTHeterogeneousValid/step2_TTbar_14TeV+Run4D127_HLTHeterogeneousValid.log
  • 37634.75137634.751_TTbar_14TeV+Run4D127_HLT75e33TimingAlpaka/step2_TTbar_14TeV+Run4D127_HLT75e33TimingAlpaka.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3435544
  • DQMHistoTests: Total failures: 22
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3435504
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

NVIDIA_H100 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 61 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 173585
  • DQMHistoTests: Total failures: 8791
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 164794
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 25 log files, 20 edm output root files, 7 DQM output files
  • TriggerResults: found differences in 1 / 6 workflows

NVIDIA_L40S Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 109 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 173585
  • DQMHistoTests: Total failures: 11186
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 162399
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 25 log files, 20 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

NVIDIA_T4 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 152 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 173585
  • DQMHistoTests: Total failures: 14739
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 158846
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 25 log files, 20 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@fwyzard

fwyzard commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

+1

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard

fwyzard commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

ignore tests-rejected with external-failure

MI300X timeouts to be investigated independently of this PR

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit d1b7409 into cms-sw:master Aug 13, 2026
22 of 24 checks passed
@sbaldu
sbaldu deleted the refactor/remove-soaconstparametersimpl branch August 13, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants