Remove explicit implementation of SoAConstParametersImpl - #51528
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51528/50247
|
|
A new Pull Request was created by @sbaldu for master. It involves the following packages:
@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
f5e09a5 to
268ea08
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51528/50410
|
|
enable gpu |
|
please test |
|
test parameters:
|
|
please test |
|
please test |
|
-1 Failed Tests: RelVals-AMD_MI300X Failed RelVals-AMD_MI300X
Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
ignore tests-rejected with external-failure MI300X timeouts to be investigated independently of this PR |
|
+1 |
This PR removes the explicit definition of the
SoAConstParametersImplstruct, and redefines it throughSoAParametersImplby moving the const qualifier in the column type template parameters. This allows to remove some duplicated code in the SoACommon backend.@Electricks94