Skip to content

Update Sherpa to v3 - #10572

Open
shimashimarin wants to merge 31 commits into
cms-sw:IB/CMSSW_20_1_X/masterfrom
shimashimarin:IB/CMSSW_17_0_X/master
Open

Update Sherpa to v3#10572
shimashimarin wants to merge 31 commits into
cms-sw:IB/CMSSW_20_1_X/masterfrom
shimashimarin:IB/CMSSW_17_0_X/master

Conversation

@shimashimarin

Copy link
Copy Markdown
Contributor

Sherpa version 3 have been released last year Sherpa release. This is a big jump of Sherpa version from v2.2.16 to v3.0.4:

  • Switch to cmake
  • Add libzip for Sherpa3
  • Add openloops inlcude folder for compiling Sherpa3

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @shimashimarin for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented May 21, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

Comment thread libzip.spec
@@ -0,0 +1,16 @@
### RPM external libzip 1.11.4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shimashimarin , @akritkbehera already have added libzip (which was needed for xrootd 6.x series) in devel branch https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_17_0_X/devel/libzip.spec . Can you please use https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_17_0_X/devel/libzip.spec so that we do not have to resolve any merge conflicts

@@ -0,0 +1,10 @@
<tool revision="1">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shimashimarin , is sherpa v3 linking against libzip.so? If yes then please add the following here

  <lib name="zip"/>

<environment name="INCLUDE" default="$TOOL_BASE/include"/>
</client>
<runtime name="PATH" value="$TOOL_BASE/bin" type="path"/>
<runtime name="ROOT_INCLUDE_PATH" value="$INCLUDE" type="path"/>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROOT_INCLUDE_PATH should only be added if the headers files of this tool end up in root dictionaries? Do you think that libzip headers will will end up in root dicts generated in cmssw (directly or indirectly via sherpa headers)? If not then please remove this line

Comment thread bz2lib.spec Outdated

%prep
%setup -n bzip2-bzip2-%{realversion}
sed -i 's/-Wl,-soname -Wl,libbz2.so.1.0/-Wl,-soname -Wl,libbz2.so.1/' Makefile-libbz2_so

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shimashimarin , I think this is not needed if you use the libzip spec from https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_17_0_X/devel/libzip.spec . @akritkbehera mentioned that if few flags are not explicitly turned OFF for libzip then it picks up system bz2lib and that is why rpm dependnecy fails. Please use the libzip from devel branch and remove this line

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuzaffar thanks for you comments. I've update libzip.spec and modified related things accordingly

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #10572 was updated.

@smuzaffar

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9c065/53413/summary.html
COMMIT: 9fac979
CMSSW: CMSSW_17_0_X_2026-05-21-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10572/53413/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Build

I found compilation error when building:

                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/sherpa/3.0.4-27726c334c06f1346e0aa71297dd8d93/include/SHERPA-MC/ATOOLS/Phys/Blob_List.H:4,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/sherpa/3.0.4-27726c334c06f1346e0aa71297dd8d93/include/SHERPA-MC/SHERPA/Main/Filter.H:6,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/sherpa/3.0.4-27726c334c06f1346e0aa71297dd8d93/include/SHERPA-MC/SHERPA/Main/Sherpa.H:7,
                 from src/GeneratorInterface/SherpaInterface/src/SherpaHepMC3Hadronizer.cc:9:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/sherpa/3.0.4-27726c334c06f1346e0aa71297dd8d93/include/SHERPA-MC/ATOOLS/Phys/Flavour.H: In constructor 'ATOOLS::Particle_Info::Particle_Info()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/sherpa/3.0.4-27726c334c06f1346e0aa71297dd8d93/include/SHERPA-MC/ATOOLS/Phys/Flavour.H:27:30: error: 'ATOOLS::Particle_Info::m_radius' will be initialized after [-Werror=reorder]
   27 |     double  m_mass, m_hmass, m_radius, m_yuk, m_width, m_dg, m_dm, m_qoverp2;
      |                              ^~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/sherpa/3.0.4-27726c334c06f1346e0aa71297dd8d93/include/SHERPA-MC/ATOOLS/Phys/Flavour.H:27:21: error:   'double ATOOLS::Particle_Info::m_hmass' [-Werror=reorder]
   27 |     double  m_mass, m_hmass, m_radius, m_yuk, m_width, m_dg, m_dm, m_qoverp2;
      |                     ^~~~~~~


@smuzaffar

Copy link
Copy Markdown
Contributor

@shimashimarin , looks like we need changes in https://github.com/cms-sw/cmssw for new sherpa

@shimashimarin

Copy link
Copy Markdown
Contributor Author

yes, the SherpaInterface should be revised. Sherpa v3 is very different from Sherpa v2. I will update SherpaInterface meanwhile

@shimashimarin

Copy link
Copy Markdown
Contributor Author

@smuzaffar forget mentioning that, I had another PR for updating SherpaInterface of Sherpa2: cms-sw/cmssw#50955. This is very useful for current Sherpa sample production. If it's merged, I will try to work on Sherpa3 CMSSW interface

@cmsbuild

cmsbuild commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Pull request #10572 was updated.

@cmsbuild

cmsbuild commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Pull request #10572 was updated.

@smuzaffar
smuzaffar changed the base branch from IB/CMSSW_17_0_X/master to IB/CMSSW_20_0_X/master June 5, 2026 16:50
CUDA Toolkit 12.9 Update 2 includes critical cuBLAS fixes for issues that could
lead to incorrect results, hangs, or invalid memory access in specific
cuBLASLtMatmul() configurations (notably ALGO_CONFIG_ID 66 across multiple
compute capabilities), as well as a ztrmm kernel correctness issue on NVIDIA Ada
and Blackwell GeForce-class GPUs.

See https://docs.nvidia.com/cuda/archive/12.9.2/cuda-toolkit-release-notes/index.html
for the release notes, bug fixes and known issues.
@akritkbehera
akritkbehera changed the base branch from IB/CMSSW_20_0_X/master to IB/CMSSW_20_1_X/master June 9, 2026 07:53
cmsbuild and others added 25 commits June 10, 2026 11:36
…owPtUtilities-to-V00-01-00

Update tag for RecoTracker-PixelLowPtUtilities to V00-01-00
…UDA_12_9_2

[17.0] Update CUDA to version 12.9.2
…es-V00-01-00

[17.0.X] Update tag for RecoTracker-PixelLowPtUtilities to V00-01-00
This overrides the value of ROCM_PATH that may be set in the system environment
and point to e.g. /opt/rocm, which can break tools like amd-smi.
…OCM_PATH

[17.0] Set `ROCM_PATH` to the CMSSW ROCm installation
…0_X/master

Update L1TSC4NGJet model to v2.0.0
Wires the new cms-hls4ml/NNPuppiTauModel package into the SCRAM build
following the L1TSC4NGJetModel/AXOL1TL precedent, so TauNNIdHW can load
its weights via hls4mlEmulator::ModelLoader instead of in-tree global
arrays (avoids the symbol-clobbering bug class in cms-sw/cmssw#49632).

Co-authored-by: artlbv <arturlbv@gmail.com>
v1.0.0 was missing NNPuppiTauModel_v1/NN/weights/w2.h, which broke
the external build (parameters.h includes it). v1.0.1 fixes this.

Co-authored-by: artlbv <arturlbv@gmail.com>
Co-authored-by: Malik Shahzad Muzaffar <shahzad.malik.muzaffar@cern.ch>
Get the sources from git to support submodules.
[17.0]Update tag for L1Trigger-L1TMuon to V01-13-00
…CX_v1.21.0

[17.0] Update UCX to version 1.21.0
[17.0] Python packages update to get security fixes
[17.0.X] Update DQM-Integration version to V00-18-02
…ation_CMSSW_17_0_X

[Backport] Add NNPuppiTauModel external spec and toolfile
@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #10572 was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants