Skip to content

Many conservative changes to make code run with both t4 and t5 - #72

Merged
MihaiSurdeanu merged 20 commits into
mainfrom
deberta-large-newtry
Mar 28, 2026
Merged

MihaiSurdeanu merged 20 commits into
mainfrom
deberta-large-newtry

Conversation

@MihaiSurdeanu

Copy link
Copy Markdown
Contributor

@kwalcock : this replaces the other PR from the branch deberta-large. I tried to be a bit more conservative here because deberta is known to be broken with transformers 5. Nevertheless, I ported over your workflow and tokenizer changes. Can you please check?

For the record: all transformer models work with transformers v4 here. With v5 all work except debertas.

@MihaiSurdeanu
MihaiSurdeanu requested a review from kwalcock March 13, 2026 23:48
@kwalcock

Copy link
Copy Markdown
Member

@MihaiSurdeanu, remember that the pre-compiled Rust tokenizer has only been updated for Linux. It's possible that the Rust code hadn't changed much between transformers versions, but I should update for Windows and Mac. If other people are using these other operating systems, they might encounter some strangeness. It's possible that different builds would be needed depending on whether transformers 4 or 5 is being used. Is the encoder.onnx.data file not a problem right now?

@MihaiSurdeanu

Copy link
Copy Markdown
Contributor Author

Thanks!

I'll get to the ONNX issue in detail tomorrow. It loads fine in the app here.

@kwalcock

Copy link
Copy Markdown
Member

@MihaiSurdeanu, I made one very small change so that the unit tests pass on Scala 3.

@MihaiSurdeanu

Copy link
Copy Markdown
Contributor Author

@kwalcock : I found this model which is very good:
https://huggingface.co/thomas-sounack/BioClinical-ModernBERT-base

Is there a tokenizer we need to add for it?
Thank you!

@kwalcock

kwalcock commented Mar 14, 2026 via email

Copy link
Copy Markdown
Member

@MihaiSurdeanu

Copy link
Copy Markdown
Contributor Author

Thanks!

Should I add the tokenizer file to resources/ now?

@kwalcock

Copy link
Copy Markdown
Member

@MihaiSurdeanu, if you'd like. I'm not certain whether you are still experimenting or already certain that it is destined for main. If I see the resource added, I can update some other files like SentencesTest.scala, TokenizersTest.scala and, TokenizerTest.scala, for example.

@MihaiSurdeanu

Copy link
Copy Markdown
Contributor Author

Testing now... I should know soon.

@MihaiSurdeanu

Copy link
Copy Markdown
Contributor Author

@kwalcock : I added the tokenizer for BioClinical-ModernBERT-base to this branch. Thank you for your help!

@MihaiSurdeanu

Copy link
Copy Markdown
Contributor Author

@kwalcock : I think is fairly stable. I'd like to merge and release. Ok with you?

@kwalcock

Copy link
Copy Markdown
Member

@MihaiSurdeanu, would you like to merge #74 first? I (or somebody) needs to check the state of the maven account. It may be that the sbt version needs to be updated before publishing and possibly some URLs changed in publish.sbt. That can happen in a different PR after this merge, however.

@MihaiSurdeanu

Copy link
Copy Markdown
Contributor Author

@MihaiSurdeanu, would you like to merge #74 first? I (or somebody) needs to check the state of the maven account. It may be that the sbt version needs to be updated before publishing and possibly some URLs changed in publish.sbt. That can happen in a different PR after this merge, however.

Merged!
My Maven account should be fine (I published a few things). I can do the release once you're Ok with this PR.

@kwalcock

Copy link
Copy Markdown
Member

@MihaiSurdeanu, that's great if the normal publishing procedure still works. Maybe they kept compatibility. Are you using Java 8 for releases? That was the intention in the past for maximum compatibility.

@MihaiSurdeanu

Copy link
Copy Markdown
Contributor Author

I don't know what I'm using... How do I check? Just check the java version in the cmd line?

@kwalcock

Copy link
Copy Markdown
Member

sbt just uses whatever it gets from the OS, so which java or java -version should tell.

@MihaiSurdeanu

Copy link
Copy Markdown
Contributor Author

It looks like I'm on Java 11 (I remember installing that with sdkman I believe a while ago).

@MihaiSurdeanu
MihaiSurdeanu merged commit efdcb22 into main Mar 28, 2026
1 check passed
@MihaiSurdeanu
MihaiSurdeanu deleted the deberta-large-newtry branch March 28, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants