test(cluster): fix barman-plugin-migration test assertions#938
Closed
aqeelat wants to merge 29 commits into
Closed
test(cluster): fix barman-plugin-migration test assertions#938aqeelat wants to merge 29 commits into
aqeelat wants to merge 29 commits into
Conversation
…g#776) Signed-off-by: Nolan Gilley <nkgilley@gmail.com> Signed-off-by: Jan Larwig <jan@larwig.com> Signed-off-by: Itay Grudev <itay+github.com@grudev.com> Co-authored-by: Nolan Gilley <nkgilley@gmail.com> Co-authored-by: Itay Grudev <itay+github.com@grudev.com>
…e-pg#927) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#926) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
…uster Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
…only Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
…ions Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
Signed-off-by: Itay Grudev <itay@verito.digital>
The barman-plugin-migration chainsaw test fails consistently in CI. The migration itself works correctly (verified against operator source and the plugin migration docs); the failures are in test assertions of transient states, plus one secret-name typo. - Migration 'Upgrading cluster' phase (step 4): status.phase is set for only a fraction of a second (the operator models rollouts as PhaseUpgrade -> PhaseWaitingForInstancesToBeActive, see tests/e2e/probes_test.go), and helm --wait does not gate CNPG CRDs, so polling always missed it. Replaced with a polling assert on the persistent UpgradingInstance Event. - Backup 'running' phase (step 5): the backup completes in ~10s, faster than polling. Replaced with a polling assert on the persistent backup 'Starting' Event (backup_controller.go:337). - PITR secret name (step 8): referenced recovery-backup-pitr-superuser (release name) instead of recovery-backup-pitr-cluster-superuser (cluster name), causing CreateContainerConfigError. Fixed. Verified end-to-end in isolated fork CI (identical test( cluster ) workflow), including PITR recovery. Signed-off-by: Abdullah Alaqel <abdullah.t.aqeel@gmail.com> Signed-off-by: Abdullah Alaqeel <abdullah.t.aqeel@gmail.com>
dosubot
Bot
added
the
size:XS
itay-grudev
force-pushed
the
feat/barman-plugin-support
branch
from
20e887c to
0ac2b24
Compare
itay-grudev
requested review from
fcanovai,
gbartolini,
leonardoce and
mnencia
as code owners
Collaborator
|
merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the consistently-failing
barman-plugin-migrationchainsaw test. The migration itself works correctly (verified against the plugin migration docs and operator source); the failures are in assertions of transient states, plus one secret-name typo.1. Migration "Upgrading cluster" phase (step 4) →
UpgradingInstanceeventstatus.phaseis set for only a fraction of a second — the operator's own e2e tests model rollouts asPhaseUpgrade → PhaseWaitingForInstancesToBeActive(tests/e2e/probes_test.go), andhelm upgrade --waitdoesn't gate CNPG CRDs (returns in ~0.5s), so polling always missed it. Replaced with a pollingasserton the persistentUpgradingInstanceEvent.2. Backup "running" phase (step 5) →
StartingeventThe backup completes in ~10s, faster than chainsaw polls. Replaced with a polling
asserton the backupStartingEvent (backup_controller.go:337).3. PITR secret name (step 8)
Referenced
recovery-backup-pitr-superuser(release name) instead ofrecovery-backup-pitr-cluster-superuser(cluster name) →CreateContainerConfigError. Fixed.Verification: passes end-to-end in isolated fork CI (identical
test( cluster )workflow), including PITR recovery — run 28597616579.Supplements #924.