-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[wrangler] Add hyperdrive planetscale signature command #15065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mtlemilio
wants to merge
1
commit into
cloudflare:main
Choose a base branch
from
mtlemilio:hyperdrive-create-planetscale-database
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+190
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| "wrangler": minor | ||
| --- | ||
|
|
||
| Add experimental `wrangler hyperdrive planetscale signature` command | ||
|
|
||
| Generates a signed authorization for creating a Cloudflare-billed PlanetScale database and prints it as JSON to stdout, so it can be piped into PlanetScale's own CLI, e.g.: | ||
|
|
||
| ```sh | ||
| SIG=$(wrangler hyperdrive planetscale signature) | ||
| pscale database create <name> --org <org> \ | ||
| --cloudflare-account-id "$(jq -r .account_id <<<"$SIG")" \ | ||
| --cloudflare-timestamp "$(jq -r .timestamp <<<"$SIG")" \ | ||
| --cloudflare-signature "$(jq -r .signature <<<"$SIG")" | ||
| ``` | ||
|
|
||
| This command is experimental and its interface may change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import { createCommand, createNamespace } from "../core/create-command"; | ||
| import { logger } from "../logger"; | ||
| import { createDatabaseSignature } from "./client"; | ||
|
|
||
| export const hyperdrivePlanetscaleNamespace = createNamespace({ | ||
| metadata: { | ||
| description: "Provision Cloudflare-billed PlanetScale databases", | ||
| status: "experimental", | ||
| owner: "Product: Hyperdrive", | ||
| }, | ||
| }); | ||
|
|
||
| export const hyperdrivePlanetscaleSignatureCommand = createCommand({ | ||
| metadata: { | ||
| description: | ||
| "Generate a signed authorization for creating a Cloudflare-billed PlanetScale database", | ||
| status: "experimental", | ||
| owner: "Product: Hyperdrive", | ||
| }, | ||
| // Print only JSON, so the output can be piped into `pscale database create`. | ||
| behaviour: { printBanner: false }, | ||
| args: {}, | ||
| async handler(_args, { config }) { | ||
| const signature = await createDatabaseSignature(config, "planetScale"); | ||
| logger.log(JSON.stringify(signature, null, 2)); | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 New Hyperdrive API call bypasses the required Cloudflare SDK
The new signing request talks to the Cloudflare API by hand-building a URL and calling the raw REST endpoint (
fetchResultatpackages/wrangler/src/hyperdrive/client.ts:195-201) instead of the official Cloudflare TypeScript SDK that the repository requires for all API access, so the call is untyped and can rely on undocumented endpoints.Impact: Contributors reading the code get an unsupported pattern, and API changes will not be caught by types.
Repository rule and current code path
The root
AGENTS.mdanti-patterns list states: "Direct Cloudflare REST API calls → use the Cloudflare TypeScript SDK", andpackages/wrangler/CONTRIBUTING.md("Integration with Cloudflare REST API") repeats that the SDK, set up for every command handler, should be preferred. The newcreateDatabaseSignature()builds/accounts/${accountId}/hyperdrive/integrationsOperations/${integration}/createDatabaseSignatureand posts viafetchResult. Note the rest ofpackages/wrangler/src/hyperdrive/client.tspredates the rule and uses the same pattern, so this may be an accepted deviation if the endpoint is not exposed by the SDK.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The underlying API endpoint hasn't been released yet. But when it is, we will update this code to use the generated Typescript SDK.