Skip to content

[miniflare] Fix dev registry test opt-in #15050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edmundhung merged 1 commit into from
Aug 6, 2026
+44 −6
Merged

[miniflare] Fix dev registry test opt-in #15050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 44 additions & 6 deletions packages/miniflare/test/dev-registry.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1846,6 +1846,7 @@ describe("registry churn across config updates", () => {
const unsafeDevRegistryPath = await useTmp();
const mf = new Miniflare({
name: "stable-worker",
unsafeRegisterWorker: true,
unsafeDevRegistryPath,
modules: true,
script: script("before"),
Expand Down Expand Up @@ -1880,6 +1881,7 @@ describe("registry churn across config updates", () => {

await mf.setOptions({
name: "stable-worker",
unsafeRegisterWorker: true,
unsafeDevRegistryPath,
modules: true,
script: script("after"),
Expand Down Expand Up @@ -1908,6 +1910,7 @@ describe("registry churn across config updates", () => {
const unsafeDevRegistryPath = await useTmp();
const mf = new Miniflare({
name: "doomed-worker",
unsafeRegisterWorker: true,
unsafeDevRegistryPath,
modules: true,
script: script("before"),
Expand All @@ -1929,6 +1932,7 @@ describe("registry churn across config updates", () => {
await expect(
mf.setOptions({
name: "doomed-worker",
unsafeRegisterWorker: true,
unsafeDevRegistryPath,
modules: true,
script: script("after"),
Expand All @@ -1951,10 +1955,20 @@ describe("registry churn across config updates", () => {
const mf = new Miniflare({
unsafeDevRegistryPath,
workers: [
{ name: "kept-worker", modules: true, script: script("kept") },
{
name: "kept-worker",
unsafeRegisterWorker: true,
modules: true,
script: script("kept"),
},
// A name that exists on `Object.prototype`, so a membership test that
// walks the prototype chain would report it as still configured.
{ name: "constructor", modules: true, script: script("dropped") },
{
name: "constructor",
unsafeRegisterWorker: true,
modules: true,
script: script("dropped"),
},
],
});
useDispose(mf);
Expand All @@ -1973,7 +1987,14 @@ describe("registry churn across config updates", () => {

await mf.setOptions({
unsafeDevRegistryPath,
workers: [{ name: "kept-worker", modules: true, script: script("kept") }],
workers: [
{
name: "kept-worker",
unsafeRegisterWorker: true,
modules: true,
script: script("kept"),
},
],
});

await vi.waitFor(
Expand All @@ -1993,8 +2014,18 @@ describe("registry churn across config updates", () => {
const mf = new Miniflare({
unsafeDevRegistryPath,
workers: [
{ name: "kept-worker", modules: true, script: script("kept") },
{ name: "dropped-worker", modules: true, script: script("dropped") },
{
name: "kept-worker",
unsafeRegisterWorker: true,
modules: true,
script: script("kept"),
},
{
name: "dropped-worker",
unsafeRegisterWorker: true,
modules: true,
script: script("dropped"),
},
],
});
useDispose(mf);
Expand All @@ -2011,7 +2042,14 @@ describe("registry churn across config updates", () => {

await mf.setOptions({
unsafeDevRegistryPath,
workers: [{ name: "kept-worker", modules: true, script: script("kept") }],
workers: [
{
name: "kept-worker",
unsafeRegisterWorker: true,
modules: true,
script: script("kept"),
},
],
});

await vi.waitFor(
Expand Down
Loading