Send first-flight transport closes after post-auth errors#2521
Open
snvtac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recv_countis still zeroCONNECTION_CLOSEonly for authenticated first-flight errors while Initial keys are still availablemissing_initial_source_connection_idto verify the server emits an Initial close that the client processes asTRANSPORT_PARAMETER_ERRORFixes #2515.
Validation
git diff --checkcargo test -p quiche missing_initial_source_connection_id -- --nocapturecargo test -p quiche invalid_initial -- --nocapturecargo test -p quiche local_error -- --nocapturecargo test -p quiche close -- --nocaptureRUSTFLAGS="-D warnings" cargo test -p quiche --all-targetsRUSTFLAGS="-D warnings" cargo clippy -p quiche --all-targets -- -D warningsRUSTFLAGS="-D warnings" cargo test --all-targets --features=async,ffi,qlog --workspaceRUSTFLAGS="-D warnings" cargo clippy --features=async,ffi,qlog --workspace -- -D warnings