Skip to content

fix: args.rs P1/P2 bugs in CLI parser #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lubov66 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −4
Open

fix: args.rs P1/P2 bugs in CLI parser #2495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apps/src/args.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,21 +369,21 @@ impl Args for ClientArgs {
None
};

let body = if args.get_bool("--body") {
std::fs::read(args.get_str("--body")).ok()
let body = if !args.get_str("--body").is_empty() {
Some(std::fs::read(args.get_str("--body")).unwrap_or_else(|e| { eprintln!("error reading --body: {e}"); std::process::exit(1); }))
} else {
None
};

let method = args.get_str("--method").to_string();

let connect_to = if args.get_bool("--connect-to") {
let connect_to = if !args.get_str("--connect-to").is_empty() {
Some(args.get_str("--connect-to").to_string())
} else {
None
};

let session_file = if args.get_bool("--session-file") {
let session_file = if !args.get_str("--session-file").is_empty() {
Some(args.get_str("--session-file").to_string())
} else {
None
Expand Down Expand Up @@ -473,6 +473,7 @@ Options:
--qpack-blocked-streams STREAMS Limit of streams that can be blocked while decoding. Any value other that 0 is currently unsupported.
--disable-gso Disable GSO (linux only).
--disable-pacing Disable pacing (linux only).
--enable-pmtud Enable Path MTU Discovery.
--initial-rtt MILLIS The initial RTT in milliseconds [default: 333].
--initial-cwnd-packets PACKETS The initial congestion window size in terms of packet count [default: 10].
-h --help Show this screen.
Expand Down