Skip to content

Bump pytest-asyncio from 1.3.0 to 1.4.0 #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wojcikstefan merged 3 commits into from
Jun 25, 2026
Merged

Bump pytest-asyncio from 1.3.0 to 1.4.0 #363

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e9e211
Bump pytest-asyncio from 1.3.0 to 1.4.0
dependabot[bot] May 30, 2026
a6d70e2
update tests after pytest-asyncio removed implicit event loop
FFX01 Jun 24, 2026
89275b8
remove unnecessary docstring
FFX01 Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,23 @@
setup_logging(TEST_CONFIG["LOG"])


@pytest.fixture
def current_event_loop():
"""
Provide a current event loop on the main thread for synchronous tests that

@wojcikstefan wojcikstefan Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the "on the main thread" mean in this context? What other threads are used?

And what does it mean to "drive the loop"? Is that some standard vocabulary? Why is calling shark.start "driving" the loop?

@FFX01 FFX01 Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the "on the main thread" mean in this context? What other threads are used?

That was referencing the error message: RuntimeError: There is no current event loop in thread 'MainThread'. Updated the description to be more clear.

And what does it mean to "drive the loop"? Is that some standard vocabulary? Why is calling shark.start "driving" the loop?

This is some weird vocab claude used when I asked it to write the comment and description. I have rewritten the description to describe the exact issue without the strange terminology. What it meant was that start() calls asyncio.get_event_loop() and loop.run_until_complete().

drive the loop themselves (e.g. they call ``shark.start()`` directly).

pytest-asyncio no longer sets a current event loop, and
``asyncio.get_event_loop()`` no longer creates one implicitly, so these
tests need an explicit loop set up and torn down around them.
Comment thread
wojcikstefan marked this conversation as resolved.
Outdated
"""
loop = asyncio.new_event_loop()
asyncio.set_event_loop(loop)
yield loop
loop.close()
asyncio.set_event_loop(None)


class aioresponses_delayed(aioresponses): # noqa
"""
Just like aioresponses, but slightly delays POST requests.
Expand All @@ -134,6 +151,7 @@ async def close(self):
await self.session.on_close()


@pytest.mark.usefixtures("current_event_loop")
class TestShark:
def test_shark_init(self):
shark = SocketShark(TEST_CONFIG)
Expand Down Expand Up @@ -2522,6 +2540,7 @@ async def dummy_send(*args):
await shark.shutdown()


@pytest.mark.usefixtures("current_event_loop")
class TestWebsocket:
"""
Test an actual WebSocket connection.
Expand Down
6 changes: 3 additions & 3 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading