Fix the inspect commands never opening the inspector#139
Merged
Conversation
sayid-tree-inspect and sayid-buf-inspect-at-point passed an expression string to cider-inspect, an API CIDER dropped long ago - the value got def'd as $s/* but the pcase on the prefix arg silently matched nothing. Go through cider-inspect-expr instead, via a shared helper. Also stop defing and inspecting garbage when there's no value at point (or nothing is selected at the prefix-arg prompt) - signal a clear user-error instead. Reported on Slack.
Now that CIDER 2.0 is out, make it the baseline for the Emacs client. Also fixes the stale CIDER 1.0+ claim in the README, which had fallen behind the actual 1.23 requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tree and buffer inspect commands (
c i) were callingcider-inspectwith an expression string, an API that's been gone from CIDER for years - the value got def'd server-side as$s/*but the inspector never opened. They now go throughcider-inspect-expr, and signal a proper error when there's no value at point instead of inspecting garbage.Also bumps the required CIDER to the just-released 2.0.
Reported on Slack.