Skip to content

fix(issue#809) spliting query param by &#1569

Open
otniel123 wants to merge 1 commit into
citrusframework:mainfrom
otniel123:query_params_fix
Open

fix(issue#809) spliting query param by &#1569
otniel123 wants to merge 1 commit into
citrusframework:mainfrom
otniel123:query_params_fix

Conversation

@otniel123

Copy link
Copy Markdown

Here I fixed the separation of query params by comma, instead, now it is separeted by ampersand (&).

@christophd

Copy link
Copy Markdown
Member

Many thanks for your contribution! I think you need to adjust the tests, too because the logic has changed. I would also love to see some new unit test that reproduces the initial error reported in #809

Apart from that I have one question. Your fix solves the commas being part of the query params, right. What about additional & characters in the new solution? Would that just hit the same error as before but now with & characters in the query params? I guess we would need to use some URL escape/unescape logic so users can use encoded strings for reserved characters such as , or &

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants