fix(arcup): verify_checksum_file rejects valid checksum files without a trailing newline - #460
Closed
UzairRehman4 wants to merge 1 commit into
Closed
UzairRehman4 wants to merge 1 commit into
UzairRehman4 wants to merge 1 commit into
Conversation
… a trailing newline read(1) returns a non-zero exit status when it hits EOF before a delimiter, even though it still populates the target variables from the partial final line. verify_checksum_file treated that non-zero status as "file is empty" and aborted, so any .sha256 file lacking a trailing newline (e.g. produced by some tools' sha256sum output) was rejected even though it contained a valid checksum. Check whether expected_checksum ended up empty instead of relying on read's exit status, which still correctly rejects a genuinely empty checksum file. Fixes circlefin#420, Fixes circlefin#448 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
UzairRehman4
requested review from
ZhiyuCircle,
ancazamfir,
romac and
sergio-mena
as code owners
September 23, 2026 09:15
Contributor
|
Hi @UzairRehman4, Thank you for your interest in contributing to Arc Node. This PR has been automatically closed because you are not assigned to issue #420. We require contributors to be explicitly assigned to an issue before submitting a PR. To contribute properly:
Please see our CONTRIBUTING.md for more details. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #420
Fixes #448
Test plan