Skip to content

Ask once at Project startup whether to merge - #129

Merged
chrisbanes merged 2 commits into
mainfrom
cb/project-merge-startup-question
Oct 19, 2026
Merged

chrisbanes merged 2 commits into
mainfrom
cb/project-merge-startup-question

Conversation

@chrisbanes

Copy link
Copy Markdown
Owner

Summary

Replace run-github-project's --auto-merge parameter with one merge-permission question at the start of next or drain. Explicit merge/no-merge instructions skip the question; delivery continues while the answer is pending.

- --auto-merge grants merging for the invocation
+ ask once at startup; no reply within 60 seconds means no merge permission
+ accept clear later approval while the same invocation remains active

If bounded nonblocking input is unavailable, post a merges-disabled message and continue without a startup wait. Preserve existing merge checks, controller ownership and ticket-local recovery. Update invocation guidance, the delivery handoff and evaluation coverage.

Evidence

  • Before: The authority contract and invocation guidance required --auto-merge or an equivalent direct instruction.
    After: The updated contract defines the startup decision, deadline, fallback and invocation expiry. Direct, novel and restraint fixtures cover these paths, including a fast next handback.
  • npm run lint, npm run evals:validate (206 cases), npm run build and git diff --check passed.
  • npm test passed: 7 Node tests and 655 Python tests, with one skip.
  • Independent standards and spec reviews passed after clarifying fresh-invocation and fallback handling. Live model evaluations were not run.

Merge Danger

Door: two-way — revert the skill and fixture changes.

Blast Radius: workflow — --auto-merge is retired and no longer grants permission. Existing invocations using it receive an explanation and follow the startup decision.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T19:17:44.529386Z ee9b14f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79f2ab58fc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/run-github-project/references/human-frontier.md Outdated
@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues remain in the reviewed changes.

Summary

Replaces --auto-merge with one startup merge decision for next and drain.

  • Project runs settle merge permission once at startup.

Reviews (2) · Last reviewed commit: "Clarify merge prompts when recovering a ..." · Reviewed by Greptile

Copy link
Copy Markdown
Owner Author

@codex review

Please review ee9b14f, including the recovery wording clarified in response to the previous finding.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: ee9b14f872

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chrisbanes
chrisbanes merged commit b0d941a into main Oct 19, 2026
2 checks passed
@chrisbanes
chrisbanes deleted the cb/project-merge-startup-question branch October 19, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant