Repository navigation
Fix URL downloads with trailing-dot titles on Windows - #1602
Merged
raivisdejus merged 2 commits intoSep 5, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
==========================================
+ Coverage 83.44% 83.52% +0.08%
==========================================
Files 111 111
Lines 12648 12683 +35
==========================================
+ Hits 10554 10594 +40
+ Misses 2094 2089 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
@raylei50653 Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filepathas the ffmpeg inputaudio.*Root cause
Buzz replaced several Windows-invalid characters in the title, but did not normalize trailing dots or spaces. For a title ending in
CVSS9., Buzz expected that literal path while yt-dlp's Windows path sanitizer createdCVSS9#. ffmpeg therefore received a nonexistent input path.The failure was then masked because Buzz treated empty stderr as success instead of checking
returncode. With-loglevel panic, ffmpeg could exit nonzero without stderr, so Buzz assigned a nonexistent WAV path and Whisper/PyAV failed later.Path boundaries
This change separates three concepts:
source.%(ext)sandaudio.wavThe sanitizer covers Windows-invalid characters, trailing dots/spaces, control characters, and reserved device names. Speaker DOCX files use the sanitized stem for the filesystem path while retaining the original title inside the document.
Regression coverage
Covers Chinese titles, invalid characters, trailing dots, trailing spaces, emoji, reserved Windows names, yt-dlp-reported paths, nonzero ffmpeg exits with empty stderr, missing WAV output, title-based regular exports, and speaker DOCX default paths.
Tested with
uv: 35 targeted tests passed, and Ruff passed.