This repository was archived by the owner on Feb 23, 2022. It is now read-only.
Conversation
ralph-dev
suggested changes
Jan 28, 2022
ralph-dev
left a comment
ralph-dev
left a comment
Member
There was a problem hiding this comment.
Why don't only the top chair leg have props and not the bottom leg? Better yet, why not just have ChairLegProps so they stay in sync ;)
Author
|
Added ChairLegProps to top and bottom chair legs. Created a Personalized Chair with square legs. |
ralph-dev
approved these changes
Jan 28, 2022
ralph-dev
left a comment
ralph-dev
left a comment
Member
There was a problem hiding this comment.
Lgtm, I would just add back chair props and seat props as well
Member
|
backChairProps Als ways add the s |
Member
|
Also why do you need a div and chair body can one of them be removed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CEM-2599
Removed unused table props and added initials on top of chair.