Skip to content

Fix support for Go 1.27 using unicode 17#51

Merged
charlievieth merged 4 commits into
charlievieth:masterfrom
pgimalac:pgimalac/go-1-27
Jul 18, 2026
Merged

Fix support for Go 1.27 using unicode 17#51
charlievieth merged 4 commits into
charlievieth:masterfrom
pgimalac:pgimalac/go-1-27

Conversation

@pgimalac

Copy link
Copy Markdown
Contributor

Generate the table for Unicode 17 to fix Go 1.27.

Fixes #50.

@pgimalac
pgimalac marked this pull request as ready for review June 26, 2026 13:55
@charlievieth

Copy link
Copy Markdown
Owner

@pgimalac thank you for this PR and will take a look at this evening / tomorrow!

@charlievieth

Copy link
Copy Markdown
Owner

Seeing some test failures that are very likely due to issues with code generation (e.g. some appear to be around ). I'm a little short on cycles at the moment, but will look into it with the goal of getting it fixed before go1.27 is released.

@pgimalac

pgimalac commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

👋 @charlievieth I don't have any failures locally, can you share what's failing / on which platform maybe ?
I'm not in a hurry but I can help :)

@stefanb

stefanb commented Jul 10, 2026

Copy link
Copy Markdown

@pgimalac, @charlievieth you can see some runtime panics in Homebrew/homebrew-core#288803, specifically strcase.UnicodeVersion "15.0.0" != unicode.Version "17.0.0"with go 1.27rc1 and:

@charlievieth

Copy link
Copy Markdown
Owner

Apologies for the delay, haven't had many free cycles lately, but there was an issue with the generated _FoldMap that caused some code points to be omitted (here the offenders were: ΐ and ΰ). This error was only visible when running tests with go version 1.27rcX.

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.45%. Comparing base (ccdc7cd) to head (fc67ae4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files           2        2           
  Lines        1938     1938           
=======================================
  Hits         1908     1908           
  Misses         30       30           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charlievieth
charlievieth merged commit ef45f18 into charlievieth:master Jul 18, 2026
15 checks passed
@charlievieth

charlievieth commented Jul 18, 2026

Copy link
Copy Markdown
Owner

First of all, thank you @pgimalac for creating this PR and @stefanb for your support of the Go ecosystem! I just cut release v0.0.6 which includes these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go 1.27rc1 bumps unicode.Version to 17.0.0

3 participants