docs: state the Playwright prerequisite for the e2e suite - #310
Merged
Merged
Conversation
The suite was committed without saying it needs Playwright, so following the README would fail with a raw module-not-found error. Playwright stays out of the project dependencies on purpose — it would add a browser download to every contributor's npm install for an optional suite — so document the one-time install instead, and have the runner print that command rather than a stack trace when the module is absent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lo4BJZPgVbFcUk5RTZkvjf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #309. The end-to-end suite was committed without documenting that it needs Playwright, so anyone following the README would hit a raw
MODULE_NOT_FOUNDstack trace.Playwright stays out of the project dependencies deliberately — adding it would put a browser download in every contributor's
npm installfor a suite that is optional and not run in CI. So:npm install --no-save playwright && npx playwright install chromiumtest/e2e/homepage.jscatches the missing module and prints that exact command instead of a stack traceVerified by temporarily removing the module and confirming the message appears.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Lo4BJZPgVbFcUk5RTZkvjf
Generated by Claude Code