ceph-dev-pipeline: use function arguments instead of environment variables #2635
Draft
shraddhaag wants to merge 2 commits into
Draft
ceph-dev-pipeline: use function arguments instead of environment variables #2635shraddhaag wants to merge 2 commits into
shraddhaag wants to merge 2 commits into
Conversation
Problem: We were hitting JVM's 64KB bytecode limit when adding new distros to the matrix stage script. Solution: Add helper functions for each stage in the matrix stage script, such that the original block is significantly reduced, thus ensuring we do not hit the JVM's 64KB limit again. This will also ensure we can keep extending the matrix with more distros without worrying about this issue. Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
This commit makes substantial changes in the ceph-dev-pipeline to move away from using environment variables. Instead, we use explicitly declared function arguments in all the helper functions in the pipeline. This makes variable mutation to be explicit, which is helpful for code readability and maintainability. Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes substantial changes in the ceph-dev-pipeline to move
away from using environment variables. Instead, we use explicitly
declared function arguments in all the helper functions in the pipeline.
This makes variable mutation to be explicit, which is helpful for code
readability and maintainability.
This PR depends on #2621. The main commit for this PR is be41014.