ceph-windows: actually disable the mgr for the vstart cluster#2630
Open
tchaikov wants to merge 1 commit into
Open
ceph-windows: actually disable the mgr for the vstart cluster#2630tchaikov wants to merge 1 commit into
tchaikov wants to merge 1 commit into
Conversation
-WITH_MGR=OFF and -WITH_LTTNG=OFF were passed to do_cmake.sh with a single dash, so cmake never set them. The mgr has therefore been built and started by every vstart run since this script was added in 2022, only to fail loading rbd_support and telemetry because their python deps were never installed. The librbd, rados and cephfs tests run against this cluster use the direct library API and do not need the mgr, so disable it as originally intended. Pass -DWITH_MGR=OFF (and -DWITH_LTTNG=OFF), and set CEPH_NUM_MGR=0 for vstart.sh so it does not try to start a ceph-mgr that is no longer built. python3-prettytable is kept: it is a client CLI dependency (ceph_daemon.py), not a mgr one. Signed-off-by: Kefu Chai <k.chai@proxmox.com>
Contributor
Author
|
this change was inspired in following warning: when investigating a windows test failure at https://jenkins.ceph.com/job/ceph-windows-pull-requests/81551/. which turns out to be a known issue tracked by https://tracker.ceph.com/issues/70847 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-WITH_MGR=OFF and -WITH_LTTNG=OFF were passed to do_cmake.sh with a single dash, so cmake never set them. The mgr has therefore been built and started by every vstart run since this script was added in 2022, only to fail loading rbd_support and telemetry because their python deps were never installed.
The librbd, rados and cephfs tests run against this cluster use the direct library API and do not need the mgr, so disable it as originally intended. Pass -DWITH_MGR=OFF (and -DWITH_LTTNG=OFF), and set CEPH_NUM_MGR=0 for vstart.sh so it does not try to start a ceph-mgr that is no longer built.
python3-prettytable is kept: it is a client CLI dependency (
ceph_daemon.py), not a mgr one.