Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
This PR inlines shared constants and simplifies issue metadata lookup while preserving existing behavior.
Changes:
- Converts shared constants to C++20 inline variables.
- Replaces map-based issue lookup with a compact array.
- Preserves issue headings and URL generation.
| File | Description |
|---|---|
src/utilities.h |
Makes shared utility constants inline. |
src/issue.cpp |
Simplifies issue metadata storage and lookup. |
src/internaltypes.h |
Makes ORIGIN_MODEL_REF inline. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hsorby
reviewed
Sep 29, 2026
Note that it's not a gtest because `ruleToInformation` is file-static in `issue.cpp` and `Issue`'s constructor and `IssueImpl` are private.
hsorby
previously approved these changes
Sep 29, 2026
hsorby
left a comment
hsorby
left a comment
Contributor
There was a problem hiding this comment.
This is a nice improvement.
Refactored the regex handling for issue reference rules to use string matching. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
hsorby
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1474.