Skip to content

Replace DockerHub based codespell with local variant - #1327

Closed
hsorby wants to merge 2 commits into
cellml:mainfrom
hsorby:dockerhub-auth
Closed

hsorby wants to merge 2 commits into
cellml:mainfrom
hsorby:dockerhub-auth

Conversation

@hsorby

@hsorby hsorby commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

@hsorby hsorby added the Infrastructure Building, hosting, testing, etc. label Sep 25, 2025
@hsorby hsorby changed the title Add DockerHub login action to avoid unauthorised errors for codespell. Replace DockerHub based codespell with local variant Sep 25, 2025
@hsorby

hsorby commented Sep 25, 2025

Copy link
Copy Markdown
Contributor Author

Instead of using a DockerHub based running of codespell this PR replaces it with a local variant which performs the same job.
It adds a codespell dictionary for any additional words that we might wish to add. It also renames the .codespellexclude to .codespell-exclude for consistency.
Shouldn’t make any difference to the output and should run faster.

@hsorby

hsorby commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

Now of course it can no longer pass the ‘Check for spelling errors’ check as it no longer exists and is replaced by ‘Check Spelling / codespell’.

@nickerso

nickerso commented Oct 5, 2025

Copy link
Copy Markdown
Contributor

Now of course it can no longer pass the ‘Check for spelling errors’ check as it no longer exists and is replaced by ‘Check Spelling / codespell’.

so we should be reviewing and merging this one without waiting for that test to pass?

@hsorby

hsorby commented Oct 5, 2025

Copy link
Copy Markdown
Contributor Author

Yes, in essence. I can change the required check but then that would change it for all PRs. In this case, you need to make sure that the ‘Check Spelling / codespell’ check is passing in lieu of the currently required ‘Check for spelling errors’.

@hsorby hsorby closed this Nov 27, 2025
@hsorby
hsorby deleted the dockerhub-auth branch November 27, 2025 00:48
@hsorby

hsorby commented Nov 27, 2025

Copy link
Copy Markdown
Contributor Author

Closing this as the associated issue has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Building, hosting, testing, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codespell CI getting rate limited

3 participants