Skip to content

Fix/mill cli readme publish status - #60

Merged
JustAGhosT merged 2 commits into
mainfrom
fix/mill-cli-readme-publish-status
Sep 2, 2026
Merged

Fix/mill cli readme publish status#60
JustAGhosT merged 2 commits into
mainfrom
fix/mill-cli-readme-publish-status

Conversation

@JustAGhosT

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactor / chore

Checklist

  • I've read CONTRIBUTING.md
  • Tests added/updated for the change (or N/A)
  • Docs updated where relevant
  • No secrets, credentials, or .env files included

Related issues

JustAGhosT and others added 2 commits August 31, 2026 01:20
Adds neuralliquid-tarmac-mill-s2s to mystira_oidc_render_audiences
alongside the existing nexamesh-coiltrace-web entry, so Tarmac's new
OpenIddict client-credentials client (companion PR in
phoenixvc/mystira-workspace) can call Mill's LaTeX-render endpoints
with a mill.render-scoped token. No dedicated resource audience was
minted on the Mystira side, so this client's own client id is the
value to allow here, matching the existing CoilTrace precedent.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@celladore/mill@0.1.0 has been on the public npm registry since 2026-08-30;
the CLI section still described publication as pending an auth/scope gate.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JustAGhosT has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 35d1453f-2ccd-482a-9633-9b6de5bf6b7c

📥 Commits

Reviewing files that changed from the base of the PR and between 0689bdc and 976a0fa.

📒 Files selected for processing (2)
  • README.md
  • infra/env/prod/terraform.tfvars

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: build-api
🔇 Additional comments (2)
README.md (1)

22-23: LGTM!

infra/env/prod/terraform.tfvars (1)

60-60: LGTM!


📝 Summary

Summary by CodeRabbit

  • Documentation

    • Updated setup and usage documentation to reflect the package’s public availability and verified command examples.
  • Bug Fixes

    • Expanded production authentication compatibility for an additional service integration.

Walkthrough

The README now documents the public npm publication of @celladore/mill@0.1.0. Production Terraform configuration now allows an additional OIDC render audience.

Changes

npm publication documentation

Layer / File(s) Summary
Document public npm publication
README.md
The CLI documentation states that @celladore/mill@0.1.0 is publicly published and removes the pending-publication notice.

Production OIDC configuration

Layer / File(s) Summary
Extend production OIDC audiences
infra/env/prod/terraform.tfvars
The production mystira_oidc_render_audiences value now includes neuralliquid-tarmac-mill-s2s alongside nexamesh-coiltrace-web.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 976a0

This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains only an unfilled template and does not explain the README or production OIDC audience changes. Describe the README publication-status correction and the addition of neuralliquid-tarmac-mill-s2s to the production OIDC audience allowlist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the README publication-status correction, which is a primary part of the changeset. It does not mention the OIDC configuration update, but a title does not need to cover e…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title clearly identifies the README publication-status correction, which is a primary part of the changeset. It does not mention the OIDC configuration update, but a title does not need to cover every change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mill-cli-readme-publish-status

Comment @coderabbitai help to get the list of available commands.

@JustAGhosT
JustAGhosT merged commit 0e60e48 into main Sep 2, 2026
11 checks passed
@JustAGhosT
JustAGhosT deleted the fix/mill-cli-readme-publish-status branch September 2, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant