data model changes

[sahusanket]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces support for different OAuth types (STANDARD, PKCE, and REFRESH_TOKEN_ROTATION) within the CDAP data pipeline. It updates OAuthProvider, OAuthStore, PutOAuthProviderRequest, and OAuthHandler to handle, store, and retrieve the new oauthType field, defaulting to STANDARD. The feedback suggests several improvements: handling potential null values in PutOAuthProviderRequest's getter to prevent NullPointerExceptions during GSON deserialization, and removing redundant @nullable annotations and null checks in OAuthProvider and OAuthStore since oauthType is guaranteed to be non-null.

[gemini-code-assist]

When PutOAuthProviderRequest is deserialized from JSON (e.g., via GSON in OAuthHandler), GSON bypasses the constructor if there is no default constructor, leaving the oauthType field as null if it is missing from the request payload. To prevent potential NullPointerExceptions in callers, the getter should return a default value of OAuthType.STANDARD if oauthType is null.

Suggested change

	public OAuthProvider.OAuthType getOAuthType() {
	return oauthType;
	}
	public OAuthProvider.OAuthType getOAuthType() {
	return oauthType == null ? OAuthProvider.OAuthType.STANDARD : oauthType;
	}

[gemini-code-assist]

The oauthType field is annotated with @Nullable, but both constructors and the builder guarantee that it is initialized to a non-null value (defaulting to OAuthType.STANDARD if null). To avoid confusion and redundant null checks, the @Nullable annotation should be removed.

Suggested change

	@Nullable
	private final OAuthType oauthType;
	private final OAuthType oauthType;

[gemini-code-assist]

Since oauthType is guaranteed to be non-null, the getOAuthType() getter should not be annotated with @Nullable.

  public OAuthType getOAuthType() {
    return oauthType;
  }

[gemini-code-assist]

Since OAuthProvider.getOAuthType() is guaranteed to be non-null, the redundant null check using Optional.ofNullable can be removed to simplify the code.

    fields.add(Fields.stringField(
            OAUTH_TYPE_COL,
            oauthProvider.getOAuthType().toString()));