Skip to content

Enforce namespace authorization on pipeline draft read endpoints #16163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adilburaksen wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −0
Open

Enforce namespace authorization on pipeline draft read endpoints #16163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...cdap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/service/DraftHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public void listDrafts(HttpServiceRequest request, HttpServiceResponder responde
@QueryParam("sortOrder") @DefaultValue("ASC") String sortOrder,
@QueryParam("filter") @Nullable String filter) {

contextAccessEnforcer.enforce(new NamespaceId(namespaceName), StandardPermission.LIST);

@gemini-code-assist gemini-code-assist Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Enforcing StandardPermission.LIST here is correct and aligns with ConnectionHandler. However, this change will cause the existing test testDraftAuthorization in DraftServiceTest.java to fail.

In DraftServiceTest.java (lines 180-183), the test only grants StandardPermission.GET to ALICE_PRINCIPAL before calling listDrafts and expecting HTTP_OK:

getPermissionManager().grant(namespaceAuthorizable,
                            ALICE_PRINCIPAL,
                            EnumSet.of(StandardPermission.GET));

Since listDrafts now enforces StandardPermission.LIST, this call will return HTTP_FORBIDDEN (403) and fail the test. Please update DraftServiceTest.java to also grant StandardPermission.LIST to Alice:

getPermissionManager().grant(namespaceAuthorizable,
                            ALICE_PRINCIPAL,
                            EnumSet.of(StandardPermission.GET, StandardPermission.LIST));

respond(namespaceName, responder, (namespace) -> {
if (!draftService.fieldExists(sortBy)) {
throw new IllegalArgumentException(String.format(
Expand All @@ -103,6 +104,7 @@ public void listDrafts(HttpServiceRequest request, HttpServiceResponder responde
public void getDraft(HttpServiceRequest request, HttpServiceResponder responder,
@PathParam("context") String namespaceName,
@PathParam("draft") String draftId) {
contextAccessEnforcer.enforce(new NamespaceId(namespaceName), StandardPermission.GET);
respond(namespaceName, responder, (namespace) -> {
String userId = "";
DraftId id = new DraftId(namespace, draftId, userId);
Expand Down