Skip to content

iOS에서 Firebase Analytics가 집계가 안되는 현상 - #44

Merged
lluke0 merged 2 commits into
developfrom
fix/firebase-ios
Aug 23, 2025
Merged

iOS에서 Firebase Analytics가 집계가 안되는 현상#44
lluke0 merged 2 commits into
developfrom
fix/firebase-ios

Conversation

@lluke0

@lluke0 lluke0 commented Aug 23, 2025

Copy link
Copy Markdown
Member

📌 PR 요약

🌱 작업한 내용

🌱 PR 포인트

📸 스크린샷

스크린샷
파일첨부바람

📮 관련 이슈

  • Resolved: #이슈번호

RCA 룰을 사용하여 코드 리뷰를 해주세요

R (Request Changes) : 적극적으로 반영을 고려해주세요
C (Comment) : 웬만하면 반영해주세요
A (Approve) : 반영해도 좋고, 넘어가도 좋습니다. 사소한 의견입니다.

Summary by CodeRabbit

  • New Features
    • 앱 시작 시 Firebase Analytics로 시작 텔레메트리를 기록합니다(플랫폼별 이벤트와 플랫폼 정보 포함).
  • Chores
    • iOS 마케팅 버전을 3.0.2로 업데이트하고 빌드 번호를 1로 재설정했습니다.
    • iOS 실행 스킴을 조정해 기본적으로 디버거 없이 실행되며, 분석 관련 런타임 인자 템플릿을 추가했습니다(비활성).

@coderabbitai

coderabbitai Bot commented Aug 23, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

앱 시작 시 Firebase Analytics로 플랫폼별 스타트업 이벤트를 기록하도록 App.kt에 로직이 추가되었습니다. iOS 프로젝트 설정에서는 빌드 번호를 1로 리셋하고 마케팅 버전을 3.0.2로 올렸으며, 실행 스킴에서 디버거를 비활성화하고 PosixSpawn 런처로 변경, 비활성화된 FIR 관련 런타임 인자를 추가했습니다.

Changes

Cohort / File(s) Change Summary
앱 초기화 텔레메트리
composeApp/src/commonMain/kotlin/com/chukchukhaksa/mobile/App.kt
LaunchedEffectcheckNeedForceUpdate() 이후 1초 지연 후 플랫폼별 이벤트명(android_startup/ios_startup)과 "platform" 파라미터로 Firebase Analytics logEvent 호출 추가. 관련 import 및 코루틴 지연 추가.
iOS 버전 메타데이터 업데이트
iosApp/iosApp.xcodeproj/project.pbxproj
CURRENT_PROJECT_VERSION 4 → 1, MARKETING_VERSION 3.0.1 → 3.0.2로 변경(여러 구성 Debug/Release에 적용). 다른 구조 변경 없음.
iOS 실행 스킴 조정
iosApp/iosApp.xcodeproj/xcshareddata/xcschemes/iosApp.xcscheme
LaunchAction에서 디버거 비우고 런처를 PosixSpawn으로 변경. 비활성화된 CommandLineArguments 3개(-FIRAnalyticsDebugEnabled, -FIRDebugDisabled, -FIRDebugEnabled) 추가.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User as 사용자
  participant App as App.kt
  participant Platform as Platform.getPlatform()
  participant FBA as Firebase Analytics

  User->>App: 앱 실행
  App->>App: checkNeedForceUpdate()
  App->>App: delay(1s)
  App->>Platform: getPlatform().name
  Platform-->>App: "Android" 또는 "iOS"
  App->>FBA: logEvent(name=android_startup/ios_startup, params: {platform})
  FBA-->>App: 기록 완료
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

Poem

귀 쫑긋, 부트 로그 띄우는 밤
토끼는 탭-탭, 이벤트 한 감
안드로이드는 폴짝, iOS는 살짝
버전은 톡, 스킴은 쏙 바꿔
별빛처럼 찍힌 텔레메트리에 띠용 ✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 04f65b1 and 24eb4d3.

📒 Files selected for processing (3)
  • composeApp/src/commonMain/kotlin/com/chukchukhaksa/mobile/App.kt (2 hunks)
  • iosApp/iosApp.xcodeproj/project.pbxproj (4 hunks)
  • iosApp/iosApp.xcodeproj/xcshareddata/xcschemes/iosApp.xcscheme (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/firebase-ios

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lluke0
lluke0 merged commit e6011bd into develop Aug 23, 2025
0 of 2 checks passed
@lluke0
lluke0 deleted the fix/firebase-ios branch August 23, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant