Ensures that Rails options are split by whitespace when generating Rails 6.y.z apps - #99
Open
jrgriffiniii wants to merge 1 commit into
Open
Conversation
apps; Ensuring that the latest Travis CI builds pass for Rails 6.0.0 with sprockets 4.0
jrgriffiniii
commented
Nov 5, 2019
| gemspec_file_path = ".internal_test_gem/internal_test_gem.gemspec" | ||
| IO.write(gemspec_file_path, | ||
| File.open(gemspec_file_path) { |f| | ||
| f.read.gsub(/(spec.add_dependency "rails".+$)/, "\\1\n spec.add_dependency 'sprockets', '~> 3.7'") |
Author
There was a problem hiding this comment.
I'm hoping that this will no longer be necessary with rails/rails#36954 (comment) in 6.0.1, as I suspect that this is related to errors raised when using 4.0.0 as the sprockets dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize if this is not the proper approach to addressing this problem, please close this if it is not fit to be merged.
I was attempting to pass
--skip-javascriptwithin the.engine_cart.ymlfile in order to test a Gem against Rails 6.0.0 releases, and found that this was not being whitespace-separated with other Rails generator arguments. Also, I found that I needed to introduce several changes to ensure that the latest Travis CI builds pass for Rails 6.0.0 with sprockets 4.0.0 releases.