feat: verify and sign the length-framed NUT-11 SIG_ALL message - #1088
Open
robwoodgate wants to merge 6 commits into
Open
feat: verify and sign the length-framed NUT-11 SIG_ALL message#1088robwoodgate wants to merge 6 commits into
robwoodgate wants to merge 6 commits into
Conversation
The mint accepts the v1 ("Cashu_SigAllSig_v1") and current message
formats, counting unique public keys with valid signatures and
ignoring signatures that do not verify. The wallet signs v1, current
and legacy so its transactions verify on mints at any upgrade stage.
Canonical vectors from the NUT-11 spec tests are pinned in the test
suite.
3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
+ Coverage 74.35% 74.46% +0.10%
==========================================
Files 115 115
Lines 13155 13175 +20
==========================================
+ Hits 9782 9811 +29
+ Misses 3373 3364 -9 ☔ View full report in Codecov by Harness. |
robwoodgate
marked this pull request as ready for review
July 17, 2026 22:32
Contributor
Author
My recommendation would be current ('v0') and the proposed 'v1' only, the legacy MTS should be dropped unilaterally. SIG_ALL is a pretty niche feature, so I think the benefit of dropping it outweighs the inconvenience to older wallets. |
Wallets sign v1 and current; the pre-0.21 message (secrets then B_ fields) is no longer produced, as it does not commit to C values or output amounts (cashubtc/nuts#404). Mint verification is unchanged.
Contributor
Author
|
I have removed the legacy signing format this PR had re-added |
# Conflicts: # cashu/mint/conditions.py # cashu/mint/ledger.py # cashu/wallet/p2pk.py # tests/mint/test_mint_conditions.py # tests/nuts/test_nut11_test_vectors.py
Restore cashu/mint/ledger.py byte-for-byte to main: the merge resolution normalized its mixed line endings, which made the whole file show as changed. Give the transaction unit test outputs even-length hex B_ values: the v1 SIG_ALL message decodes them to raw bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the length-framed NUT-11 SIG_ALL message aggregation (
Cashu_SigAllSig_v1) proposed in cashubtc/nuts#404. The new format matches the domain separation and length framing already used for NUT-20 mint quote signatures.tests/11-test.mdare pinned intests/nuts/test_nut11_test_vectors.pyDraft until cashubtc/nuts#404 settles.